Issue 11639037: Accumulate FileSystemUsageCache updates.

Issue 11639037: Accumulate FileSystemUsageCache updates. (Closed)

Created:
8 years ago by tzik

Modified:
7 years, 11 months ago

Reviewers:
kinuko

CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, Yusuke Sato

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Accumulate FileSystemUsageCache updates to improve write performance. This change reduces the number of usage cache update on appending data to a file, and improves the write performance from 75.72 MB/s (σ = 23.255) to 229.238 MB/s (σ = 31.442) on a benchmark. https://www.googledrive.com/host/0B0EZi1x_1MtFSnNRZy1nalVNdlk/append-write.html BUG=166158 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175474

Patch Set 1 #

Patch Set 2 : test fix, change to URL based accum to path based accum #

Patch Set 3 : testfix #

Total comments: 4

Patch Set 4 : drop Unretained #

Total comments: 4

Patch Set 5 : skip update task for invalid usage cache #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -6 lines)			Patch
M	webkit/fileapi/local_file_system_quota_unittest.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/fileapi/obfuscated_file_util_unittest.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/fileapi/sandbox_quota_observer.h	View	1 2 3	4 chunks	+14 lines, -0 lines	0 comments	Download
M	webkit/fileapi/sandbox_quota_observer.cc	View	1 2 3 4	4 chunks	+44 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

kinuko

(Sorry for super long delay) The new number sounds awesome!! https://codereview.chromium.org/11639037/diff/4003/webkit/fileapi/sandbox_quota_observer.cc File webkit/fileapi/sandbox_quota_observer.cc (right): https://codereview.chromium.org/11639037/diff/4003/webkit/fileapi/sandbox_quota_observer.cc#newcode47 ...

7 years, 11 months ago (2013-01-01 04:26:23 UTC) #2

tzik

Updated! PTAL. https://codereview.chromium.org/11639037/diff/4003/webkit/fileapi/sandbox_quota_observer.cc File webkit/fileapi/sandbox_quota_observer.cc (right): https://codereview.chromium.org/11639037/diff/4003/webkit/fileapi/sandbox_quota_observer.cc#newcode47 webkit/fileapi/sandbox_quota_observer.cc:47: base::Unretained(this))); On 2013/01/01 04:26:23, kinuko wrote: > ...

7 years, 11 months ago (2013-01-07 06:06:12 UTC) #3

kinuko

lgtm with nits https://codereview.chromium.org/11639037/diff/11001/webkit/fileapi/sandbox_quota_observer.cc File webkit/fileapi/sandbox_quota_observer.cc (right): https://codereview.chromium.org/11639037/diff/11001/webkit/fileapi/sandbox_quota_observer.cc#newcode43 webkit/fileapi/sandbox_quota_observer.cc:43: FilePath usage_file_path = GetUsageCachePath(url); should we ...

7 years, 11 months ago (2013-01-07 06:38:25 UTC) #4

tzik

https://codereview.chromium.org/11639037/diff/11001/webkit/fileapi/sandbox_quota_observer.cc File webkit/fileapi/sandbox_quota_observer.cc (right): https://codereview.chromium.org/11639037/diff/11001/webkit/fileapi/sandbox_quota_observer.cc#newcode43 webkit/fileapi/sandbox_quota_observer.cc:43: FilePath usage_file_path = GetUsageCachePath(url); On 2013/01/07 06:38:25, kinuko wrote: ...

7 years, 11 months ago (2013-01-07 16:00:37 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/11639037/21002

7 years, 11 months ago (2013-01-07 16:01:33 UTC) #6

commit-bot: I haz the power

7 years, 11 months ago (2013-01-07 17:30:16 UTC) #7

Retried try job too often on win_aura for step(s) unit_tests

Expand Messages | Collapse Messages