Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 11639012: Add tests to verify accelerators properly work on constrained window. (Closed)

Created:
8 years ago by mazda
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Add tests to verify accelerators properly work on constrained window. - Add ConstrainedWindowViewTest.BackspaceSentToWebContent for Aura. - Add ConstrainedWindowViewTest.EscapeCloseConstrainedWindow, which verifies that escape key closes the constrained window. - Extract TestWindowObserver to ui/views/test from bubble_delegate_unittest.cc BUG=156437 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175739

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 6

Patch Set 8 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -48 lines) Patch
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 1 2 3 4 5 6 7 2 chunks +79 lines, -15 lines 0 comments Download
M ui/views/bubble/bubble_delegate_unittest.cc View 1 2 5 chunks +4 lines, -33 lines 0 comments Download
A ui/views/test/test_widget_observer.h View 1 2 3 4 5 6 7 1 chunk +37 lines, -0 lines 0 comments Download
A ui/views/test/test_widget_observer.cc View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mazda
Could you review this CL?
8 years ago (2012-12-21 03:31:50 UTC) #1
sky
Mike is in the process of renaming constrained windows: https://codereview.chromium.org/11633052/ . Can you wait until ...
8 years ago (2012-12-21 15:46:01 UTC) #2
mazda
Please take another look. https://codereview.chromium.org/11639012/diff/4008/chrome/browser/ui/views/constrained_window_views_browsertest.cc File chrome/browser/ui/views/constrained_window_views_browsertest.cc (right): https://codereview.chromium.org/11639012/diff/4008/chrome/browser/ui/views/constrained_window_views_browsertest.cc#newcode331 chrome/browser/ui/views/constrained_window_views_browsertest.cc:331: #if defined(OS_WIN) On 2012/12/21 15:46:01, ...
7 years, 11 months ago (2013-01-07 22:41:13 UTC) #3
sky
LGTM
7 years, 11 months ago (2013-01-08 01:17:17 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 01:25:29 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698