Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1163853002: Revert of [es6] implement default parameters via desugaring (Closed)

Created:
5 years, 6 months ago by caitp (gmail)
Modified:
5 years, 6 months ago
CC:
v8-dev, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] implement default parameters via desugaring (patchset #19 id:380001 of https://codereview.chromium.org/1127063003/) Reason for revert: Broken on arm64 Original issue's description: > [es6] implement default parameters via desugaring > > Stage 1 implementation: > > - Parameters can't be referenced before initialized (from left-to-right) > - SingleNameBindings only, no support for BindingPatterns > > Known issues: > > - Incorrect scoping (parameter expressions may reference variables declared in function body) > - Function arity is untouched > - Hole-checking needs work > - Rest parameters are broken when mixed with optional arguments > > BUG=v8:2160 > LOG=N > R=arv@chromium.org, rossberg@chromium.org > > Committed: https://crrev.com/892c85485881f8be2f17bd83238980f858126576 > Cr-Commit-Position: refs/heads/master@{#28739} TBR=rossberg@chromium.org,wingo@igalia.com,arv@chromium.org,dslomov@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2160 Committed: https://crrev.com/904fbc303a759de5d1d83667a1203f44a8ef9760 Cr-Commit-Position: refs/heads/master@{#28740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -502 lines) Patch
M src/bootstrapper.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/parser.h View 3 chunks +3 lines, -7 lines 0 comments Download
M src/parser.cc View 7 chunks +6 lines, -152 lines 0 comments Download
M src/preparser.h View 11 chunks +6 lines, -49 lines 0 comments Download
M src/preparser.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/scopes.h View 5 chunks +1 line, -15 lines 0 comments Download
M src/scopes.cc View 8 chunks +11 lines, -33 lines 0 comments Download
M src/variables.h View 1 chunk +0 lines, -4 lines 0 comments Download
D test/mjsunit/harmony/default-parameters.js View 1 chunk +0 lines, -143 lines 0 comments Download
D test/mjsunit/harmony/default-parameters-debug.js View 1 chunk +0 lines, -65 lines 0 comments Download
D test/mjsunit/harmony/default-parameters-lazy.js View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
caitp (gmail)
Created Revert of [es6] implement default parameters via desugaring
5 years, 6 months ago (2015-06-01 18:30:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163853002/1
5 years, 6 months ago (2015-06-01 18:30:47 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-01 18:30:49 UTC) #4
arv (Not doing code reviews)
LGTM
5 years, 6 months ago (2015-06-01 18:33:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163853002/1
5 years, 6 months ago (2015-06-01 18:34:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 18:35:04 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 18:35:13 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/904fbc303a759de5d1d83667a1203f44a8ef9760
Cr-Commit-Position: refs/heads/master@{#28740}

Powered by Google App Engine
This is Rietveld 408576698