Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 1163843010: Oilpan: Remove Heap::s_markingVisitor (Closed)

Created:
4 years, 11 months ago by haraken
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, keishi
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Remove Heap::s_markingVisitor In preparation for introducing a visitor for a snapshot GC, this CL removes Heap::s_markingVisitor as a global variable. BUG=490087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196573

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -27 lines) Patch
M Source/platform/heap/Heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/heap/Heap.cpp View 1 13 chunks +24 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
haraken
PTAL
4 years, 11 months ago (2015-06-05 07:20:26 UTC) #2
keishi
LGTM
4 years, 11 months ago (2015-06-05 09:55:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163843010/20001
4 years, 11 months ago (2015-06-05 12:33:39 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2015-06-05 13:38:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196573

Powered by Google App Engine
This is Rietveld 408576698