Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1163843006: [NaCl SDK] Use seperate build dir for msan/tsan builds (Closed)

Created:
5 years, 6 months ago by Sam Clegg
Modified:
5 years, 6 months ago
Reviewers:
binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Use seperate build dir for msan/tsan builds This ensures that everything gets rebuilt with correct cflags/ldflags. Add Release as well as msan_Release to the link line since not all libraries get rebuild in this mode (some core libraries such as libppapi still only exist in the Release director). Committed: https://crrev.com/1460c4b34f2dbfc37f5934380f362e2193f64360 Cr-Commit-Position: refs/heads/master@{#332453}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -38 lines) Patch
M native_client_sdk/src/build_tools/test_sdk.py View 1 chunk +0 lines, -6 lines 0 comments Download
M native_client_sdk/src/tools/common.mk View 1 1 chunk +10 lines, -3 lines 0 comments Download
M native_client_sdk/src/tools/host_gcc.mk View 1 2 chunks +5 lines, -5 lines 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 1 9 chunks +24 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sam Clegg
5 years, 6 months ago (2015-06-02 02:48:01 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163843006/20001
5 years, 6 months ago (2015-06-02 02:48:28 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-02 02:51:54 UTC) #6
binji
nice, lgtm
5 years, 6 months ago (2015-06-02 18:04:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163843006/20001
5 years, 6 months ago (2015-06-02 19:33:26 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-02 19:53:06 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 19:54:52 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1460c4b34f2dbfc37f5934380f362e2193f64360
Cr-Commit-Position: refs/heads/master@{#332453}

Powered by Google App Engine
This is Rietveld 408576698