Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Issue 1163833004: Add BROWSABLE intent to Mandoline AndroidManifest.xml (Closed)

Created:
5 years, 6 months ago by msw
Modified:
5 years, 6 months ago
Reviewers:
Jay Civelli, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add BROWSABLE intent to Mandoline AndroidManifest.xml Building mandoline/app/android:mandoline_apk yields: ACTION //mandoline/app/android:mando...e_apk__java__lint(//build/toolchain/android:arm) AndroidManifest.xml:27 Activity supporting ACTION_VIEW is not set as BROWSABLE: AppIndexingWarning [warning] ... The result.xml additionally explains: summary="Missing App Indexing Support" explanation="Ensures the app can correctly handle deep links and integrate with App Indexing for Google search." BUG=NONE TEST=No Android build lint issues; no regressions. R=sky@chromium.org,jcivelli@chromium.org Committed: https://crrev.com/4f1b796f1d80bc180830321516a9d5e1581fffef Cr-Commit-Position: refs/heads/master@{#333221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M mandoline/app/android/apk/AndroidManifest.xml View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/runner/android/apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
msw
Hey Jay, please take a look; thanks!
5 years, 6 months ago (2015-06-05 23:57:27 UTC) #2
sky
LGTM
5 years, 6 months ago (2015-06-06 18:01:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163833004/1
5 years, 6 months ago (2015-06-07 00:38:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-07 00:46:05 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-07 00:46:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f1b796f1d80bc180830321516a9d5e1581fffef
Cr-Commit-Position: refs/heads/master@{#333221}

Powered by Google App Engine
This is Rietveld 408576698