Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 1163833003: Add cmap 3,0 (symbol) as Unicode fallback. (Closed)

Created:
5 years, 6 months ago by bungeman-skia
Modified:
5 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add cmap 3,0 (symbol) as Unicode fallback. FreeType automatically selects the 'most Unicode' cmap available, otherwise the default cmap is NULL. When this happens the fallback should include the 3,0 symbol cmap, as is outlined in the Apple TrueType documentation. This cmap should effectively be a Unicode mapping, but exclusively in the private use area. BUG=skia:1873, chromium:489452 Committed: https://skia.googlesource.com/skia/+/726cf9038aae3f4dffc79a97645388f32224b22d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -45 lines) Patch
A + resources/fonts/SpiderSymbol.ttf View Binary file 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 3 chunks +19 lines, -45 lines 0 comments Download
M tests/FontHostTest.cpp View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163833003/1
5 years, 6 months ago (2015-06-05 19:53:51 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-05 20:00:00 UTC) #4
bungeman-skia
5 years, 6 months ago (2015-06-05 20:27:35 UTC) #6
reed1
lgtm
5 years, 6 months ago (2015-06-05 20:35:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163833003/1
5 years, 6 months ago (2015-06-05 20:37:28 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:38:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/726cf9038aae3f4dffc79a97645388f32224b22d

Powered by Google App Engine
This is Rietveld 408576698