Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 11638053: Make crash bubble send onRestarted() to apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_contents_service.cc
diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc
index bb25f9bc450cf620bd27f519a3e340ad03dd7b42..50a0671dd8bab12639c60317969eac25bc77be25 100644
--- a/chrome/browser/background/background_contents_service.cc
+++ b/chrome/browser/background/background_contents_service.cc
@@ -65,6 +65,7 @@ class CrashNotificationDelegate : public NotificationDelegate {
const Extension* extension)
: profile_(profile),
is_hosted_app_(extension->is_hosted_app()),
+ is_platform_app_(extension->is_platform_app()),
extension_id_(extension->id()) {
}
@@ -85,7 +86,7 @@ class CrashNotificationDelegate : public NotificationDelegate {
service->LoadBackgroundContentsForExtension(profile_, extension_id_);
} else {
benwells 2012/12/21 03:48:55 Is this meant to be if (is_platform_app_) {?
koz (OOO until 15th September) 2012/12/21 04:36:50 Yes, yes it is. Done.
extensions::ExtensionSystem::Get(profile_)->extension_service()->
- ReloadExtension(extension_id_);
+ ReloadExtensionWithRestartEvent(extension_id_);
}
// Closing the balloon here should be OK, but it causes a crash on Mac
@@ -106,6 +107,7 @@ class CrashNotificationDelegate : public NotificationDelegate {
Profile* profile_;
bool is_hosted_app_;
+ bool is_platform_app_;
std::string extension_id_;
DISALLOW_COPY_AND_ASSIGN(CrashNotificationDelegate);
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.h » ('j') | chrome/browser/extensions/extension_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698