Make crash bubble send onRestarted() to apps.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <set>
 
@@ skipping 690 matching lines @@
   installer->InstallCrx(extension_path);
 
   if (out_crx_installer)
     *out_crx_installer = installer;
 
   return true;
 }
 
 void ExtensionService::ReloadExtension(const std::string& extension_id) {
   int events = HasShellWindows(extension_id) ? EVENT_LAUNCHED : EVENT_NONE;
   ReloadExtensionWithEvents(extension_id, events);

[koz (OOO until 15th September), 2012/12/21 02:44:08]

Do you know if there's a reason why these methods only send events if they had
windows open? It would simplify things if they always launched an event.

 }
 
 void ExtensionService::RestartExtension(const std::string& extension_id) {

[benwells, 2012/12/21 03:48:55]

I don't understand why RestartExtension only restarts if it has shell windows
open. I think that is incorrect, which means we can merge this with
ReloadExtensionWithRestartEvent.

[koz (OOO until 15th September), 2012/12/21 04:36:50]

Done.

   int events = HasShellWindows(extension_id) ? EVENT_RESTARTED : EVENT_NONE;
   ReloadExtensionWithEvents(extension_id, events);
 }
 
+void ExtensionService::ReloadExtensionWithRestartEvent(
+    const std::string& extension_id) {
+  ReloadExtensionWithEvents(extension_id, EVENT_RESTARTED);
+}
+
 void ExtensionService::ReloadExtensionWithEvents(
     const std::string& extension_id,
     int events) {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   FilePath path;
   const Extension* current_extension = GetExtensionById(extension_id, false);
 
   // Disable the extension if it's loaded. It might not be loaded if it crashed.
   if (current_extension) {
     // If the extension has an inspector open for its background page, detach
@@ skipping 2402 matching lines @@
     scoped_refptr<const Extension> extension = GetInstalledExtension(*it);
     DCHECK(extension);
     if (!extension)
       continue;
     blacklisted_extensions_.Insert(extension);
     UnloadExtension(*it, extension_misc::UNLOAD_REASON_BLACKLIST);
   }
 
   IdentifyAlertableExtensions();
 }