Remove most uses of StringInputBuffer

src/objects.h

Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 83a05ade808f32d32ad08889741182da50bbddf8..ec173e4f990043b395f7efa43345aa9c7ccbb60d 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -7197,9 +7197,7 @@ class String: public HeapObject {
   // Returns a hash value used for the property table
   inline uint32_t Hash();
 
-  static bool ComputeArrayIndex(unibrow::CharacterStream* buffer,
-                                uint32_t* index,
-                                int length);
+  bool ComputeArrayIndex(uint32_t* index);
 
   // Externalization.
   bool MakeExternal(v8::String::ExternalStringResource* resource);
@@ -7894,12 +7892,14 @@ class ConsStringIteratorOp {
 // Note: this class is not GC-safe.
 class StringCharacterStream {
  public:
+  inline StringCharacterStream(String* string, ConsStringIteratorOp* op);
   inline StringCharacterStream(String* string,
                                unsigned offset,
                                ConsStringIteratorOp* op);
   inline uint16_t GetNext();
   inline bool HasMore();
-  inline void Reset(String* string, unsigned offset, ConsStringIteratorOp* op);
+  inline void Reset(String* string) { Reset(string, 0); }
+  inline void Reset(String* string, unsigned offset);

[Yang, 2012/12/21 09:21:48]

Save a line using optional argument with default value :)

   inline void VisitOneByteString(const uint8_t* chars, unsigned length);
   inline void VisitTwoByteString(const uint16_t* chars, unsigned length);