cc: Implement RemoveLast for DisplayItemList.

cc/base/list_container.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/base/list_container.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "cc/base/scoped_ptr_vector.h"
@@ skipping 35 matching lines @@
       DCHECK_LE(position, LastElement());
       DCHECK_GE(position, Begin());
       char* start = position + step;
       std::copy(start, End(), position);
 
       --size;
       // Decrease capacity to avoid creating not full not last InnerList.
       --capacity;
     }
 
+    bool IsEmpty() const { return !size; }
     bool IsFull() { return capacity == size; }
     size_t NumElementsAvailable() const { return capacity - size; }
 
     void* AddElement() {
       DCHECK_LT(size, capacity);
       ++size;
       return LastElement();
     }
 
+    void RemoveLast() {
+      DCHECK(!IsEmpty());
+      --size;
+    }
+
     char* Begin() const { return data.get(); }
     char* End() const { return data.get() + size * step; }
     char* LastElement() const { return data.get() + (size - 1) * step; }
     char* ElementAt(size_t index) const { return data.get() + index * step; }
 
    private:
     DISALLOW_COPY_AND_ASSIGN(InnerList);
   };
 
   explicit ListContainerCharAllocator(size_t element_size)
       : element_size_(element_size),
         size_(0),
-        list_count_(0),
+        last_list_index_(0),
         last_list_(NULL) {
     AllocateNewList(kDefaultNumElementTypesToReserve);
+    last_list_ = storage_[last_list_index_];
   }
 
   ListContainerCharAllocator(size_t element_size, size_t element_count)
       : element_size_(element_size),
         size_(0),
-        list_count_(0),
+        last_list_index_(0),
         last_list_(NULL) {
     AllocateNewList(element_count > 0 ? element_count
                                       : kDefaultNumElementTypesToReserve);
+    last_list_ = storage_[last_list_index_];
   }
 
   ~ListContainerCharAllocator() {}
 
   void* Allocate() {
-    if (last_list_->IsFull())
-      AllocateNewList(last_list_->capacity * 2);
+    if (last_list_->IsFull()) {
+      // Only allocate a new list if there isn't a spare one still there from
+      // previous usage.
+      if (last_list_index_ + 1 >= storage_.size())
+        AllocateNewList(last_list_->capacity * 2);
+
+      ++last_list_index_;
+      last_list_ = storage_[last_list_index_];
+    }
 
     ++size_;
     return last_list_->AddElement();
   }
 
   size_t element_size() const { return element_size_; }
-  size_t list_count() const { return list_count_; }
+  size_t list_count() const { return storage_.size(); }
   size_t size() const { return size_; }
   bool IsEmpty() const { return size() == 0; }
 
   size_t Capacity() const {
     size_t capacity_sum = 0;
     for (ScopedPtrVector<InnerList>::const_iterator iter = storage_.begin();
          iter != storage_.end(); ++iter) {
       capacity_sum += (*iter)->capacity;
     }
     return capacity_sum;
   }
 
   void Clear() {
     size_t initial_allocation_size = storage_.front()->capacity;
     storage_.clear();
-    list_count_ = 0;
     last_list_ = NULL;
+    last_list_index_ = 0;
     size_ = 0;
     AllocateNewList(initial_allocation_size);
+    last_list_ = storage_[0];

[danakj, 2015/06/03 23:21:23]

nit: storage_[last_list_index_]

[jbroman, 2015/06/04 00:00:47]

Done.

+  }
+
+  void RemoveLast() {
+    DCHECK(!IsEmpty());
+    last_list_->RemoveLast();
+    if (last_list_->IsEmpty() && last_list_index_ > 0) {
+      --last_list_index_;
+      last_list_ = storage_[last_list_index_];
+
+      // If there are now two empty inner lists, free one of them.
+      if (last_list_index_ + 2 < storage_.size())
+        storage_.pop_back();
+    }
+    --size_;
   }
 
   void Erase(PositionInListContainerCharAllocator position) {
     DCHECK_EQ(this, position.ptr_to_container);
     storage_[position.vector_index]->Erase(position.item_iterator);
     // TODO(weiliangc): Free the InnerList if it is empty.
     --size_;
   }
 
   InnerList* InnerListById(size_t id) const {
-    DCHECK_LT(id, list_count_);
+    DCHECK_LT(id, storage_.size());
     return storage_[id];
   }
 
   size_t FirstInnerListId() const {
     // |size_| > 0 means that at least one vector in |storage_| will be
     // non-empty.
     DCHECK_GT(size_, 0u);
     size_t id = 0;
     while (storage_[id]->size == 0)
       ++id;
     return id;
   }
 
   size_t LastInnerListId() const {
     // |size_| > 0 means that at least one vector in |storage_| will be
     // non-empty.
     DCHECK_GT(size_, 0u);
-    size_t id = list_count_ - 1;
+    size_t id = storage_.size() - 1;
     while (storage_[id]->size == 0)
       --id;
     return id;
   }
 
-  void AllocateNewList(size_t list_size) {
-    ++list_count_;
-    scoped_ptr<InnerList> new_list(new InnerList);
-    storage_.push_back(new_list.Pass());
-    last_list_ = storage_.back();
-    InnerList* list = last_list_;
-    list->capacity = list_size;
-    list->size = 0;
-    list->step = element_size_;
-    list->data.reset(new char[list->capacity * list->step]);
-  }
-
   size_t NumAvailableElementsInLastList() const {
     return last_list_->NumElementsAvailable();
   }
 
  private:
+  void AllocateNewList(size_t list_size) {
+    scoped_ptr<InnerList> new_list(new InnerList);
+    new_list->capacity = list_size;
+    new_list->size = 0;
+    new_list->step = element_size_;
+    new_list->data.reset(new char[list_size * element_size_]);
+    storage_.push_back(new_list.Pass());
+  }
+
   ScopedPtrVector<InnerList> storage_;
   const size_t element_size_;
+
+  // The number of elements in the list.
   size_t size_;
-  size_t list_count_;
+
+  // The index of the last list to have had elements added to it, or the only
+  // list if the container has not had elements added since being cleared.
+  size_t last_list_index_;
+
+  // storage_[last_list_index_]

[danakj, 2015/06/03 23:21:23]

can you make this a sentence?

[jbroman, 2015/06/04 00:00:47]

Done.

   InnerList* last_list_;
 
   DISALLOW_COPY_AND_ASSIGN(ListContainerCharAllocator);
 };
 
 // PositionInListContainerCharAllocator
 //////////////////////////////////////////////////////
 ListContainerBase::PositionInListContainerCharAllocator::
     PositionInListContainerCharAllocator(
         const ListContainerBase::PositionInListContainerCharAllocator& other)
@@ skipping 81 matching lines @@
 
 ListContainerBase::ListContainerBase(size_t max_size_for_derived_class,
                                      size_t num_of_elements_to_reserve_for)
     : data_(new ListContainerCharAllocator(max_size_for_derived_class,
                                            num_of_elements_to_reserve_for)) {
 }
 
 ListContainerBase::~ListContainerBase() {
 }
 
+void ListContainerBase::RemoveLast() {
+  data_->RemoveLast();
+}
+
 void ListContainerBase::EraseAndInvalidateAllPointers(
     ListContainerBase::Iterator position) {
   data_->Erase(position);
 }
 
 ListContainerBase::ConstReverseIterator ListContainerBase::crbegin() const {
   if (data_->IsEmpty())
     return crend();
 
   size_t id = data_->LastInnerListId();
@@ skipping 179 matching lines @@
 }
 
 ListContainerBase::ConstReverseIterator::~ConstReverseIterator() {
 }
 
 size_t ListContainerBase::ConstReverseIterator::index() const {
   return index_;
 }
 
 }  // namespace cc