Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Side by Side Diff: test/cctest/test-global-handles.cc

Issue 1163803002: Cosmetic changes to tests to make it easier to concatenate them. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 11 matching lines...) Expand all
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include "src/global-handles.h" 28 #include "src/global-handles.h"
29 29
30 #include "test/cctest/cctest.h" 30 #include "test/cctest/cctest.h"
31 31
32 namespace test_global_handles {
33
32 using namespace v8::internal; 34 using namespace v8::internal;
33 using v8::UniqueId; 35 using v8::UniqueId;
34 36
35 37
36 static List<Object*> skippable_objects; 38 static List<Object*> skippable_objects;
37 static List<Object*> can_skip_called_objects; 39 static List<Object*> can_skip_called_objects;
38 40
39 41
40 static bool CanSkipCallback(Heap* heap, Object** pointer) { 42 static bool CanSkipCallback(Heap* heap, Object** pointer) {
41 can_skip_called_objects.Add(*pointer); 43 can_skip_called_objects.Add(*pointer);
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 { 375 {
374 HandleScope scope(isolate); 376 HandleScope scope(isolate);
375 v8::Local<v8::Object> object = v8::Object::New(v8_isolate); 377 v8::Local<v8::Object> object = v8::Object::New(v8_isolate);
376 v8::Eternal<v8::Object> eternal(v8_isolate, object); 378 v8::Eternal<v8::Object> eternal(v8_isolate, object);
377 CHECK(!eternal.IsEmpty()); 379 CHECK(!eternal.IsEmpty());
378 CHECK(object == eternal.Get(v8_isolate)); 380 CHECK(object == eternal.Get(v8_isolate));
379 } 381 }
380 382
381 CHECK_EQ(2*kArrayLength + 1, eternal_handles->NumberOfHandles()); 383 CHECK_EQ(2*kArrayLength + 1, eternal_handles->NumberOfHandles());
382 } 384 }
385 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698