chrome/browser/extensions/browser_event_router.cc - Issue 11638022: Consolidate [BrowserAction,PageAction,ScriptBadge]API into ExtensionActionAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_event_router.cc

Issue 11638022: Consolidate [BrowserAction,PageAction,ScriptBadge]API into ExtensionActionAPI (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_script_badge

Patch Set: nits Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/system_indicator/system_indicator_api.h ('k') | chrome/browser/extensions/extension_function_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/browser_event_router.cc

diff --git a/chrome/browser/extensions/browser_event_router.cc b/chrome/browser/extensions/browser_event_router.cc

index cc33832268da0ac2da252a90a1707a744623918e..aa51658ede4ad95c6440c1ba0ec2dff042854da9 100644

--- a/chrome/browser/extensions/browser_event_router.cc

+++ b/chrome/browser/extensions/browser_event_router.cc

@@ -30,7 +30,7 @@

namespace events = extensions::event_names;

namespace tab_keys = extensions::tabs_constants;

-namespace page_action_keys = extension_page_actions_api_constants;

+namespace extension_action_keys = extension_page_actions_api_constants;

Yoyo Zhou 2013/01/02 21:56:05 I think this should also go back to being page_act

Devlin 2013/01/16 21:07:31 Done.

using content::NavigationController;

using content::WebContents;

@@ -503,7 +503,8 @@ void BrowserEventRouter::DispatchOldPageActionEvent(

DictionaryValue* data = new DictionaryValue();

data->Set(tab_keys::kTabIdKey, Value::CreateIntegerValue(tab_id));

data->Set(tab_keys::kTabUrlKey, Value::CreateStringValue(url));

- data->Set(page_action_keys::kButtonKey, Value::CreateIntegerValue(button));

+ data->Set(extension_action_keys::kButtonKey,

+ Value::CreateIntegerValue(button));

args->Append(data);

DispatchEventToExtension(profile, extension_id, "pageActions", args.Pass(),