Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: editor/tools/features/com.google.dart.tools.tests.feature_releng/buildTests.xml

Issue 11638015: Fix 2 failing tests on windows. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « editor/build/promote.py ('k') | editor/tools/plugins/com.google.dart.tools.core/META-INF/MANIFEST.MF » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/features/com.google.dart.tools.tests.feature_releng/buildTests.xml
===================================================================
--- editor/tools/features/com.google.dart.tools.tests.feature_releng/buildTests.xml (revision 16302)
+++ editor/tools/features/com.google.dart.tools.tests.feature_releng/buildTests.xml (working copy)
@@ -172,14 +172,13 @@
</move>
</target>
- <!-- We have not set "failonerror='true'" for either the test runner
- or test collector, because we want the HTML report to be generated
- even when the tests fail. Unfortunately, this will cause ant to
- report "BUILD SUCCESSFUL, even if the tests fail. To get around this
- problem, the -check_results task will parse the generated XML report
- and look for the substrings 'failures="0"' and 'errors="0"'. If either
- of these strings cannot be found, then a <fail> task is run.-->
- <target name="check_results" depends="generateHtml">
+ <!-- The -check_results task parses the generated XML report and looks for
+ the substrings 'failures="0"' and 'errors="0"'. If eitherof these
+ strings cannot be found, then a <fail> task is run.-->
+ <target name="check_results">
+ <copy
+ file="${build.test.reports.dir}/TEST-${build.test.suite}.xml"
+ tofile="${build.out}/test-results.xml"/>
<loadfile
srcfile="${build.test.reports.dir}/TEST-${build.test.suite}.xml"
@@ -213,19 +212,6 @@
</target>
<!--
- create an HTML version of the Junit output
- -->
- <target name="generateHtml">
- <junitreport>
- <fileset dir="${build.test.reports.dir}">
- <include name="TEST-${build.test.suite}.xml" />
- </fileset>
- <report todir="${build.out}/html" >
- </report>
- </junitreport>
- </target>
-
- <!--
deploy the tests to the out directory so they cna be used by the test runner
-->
<target name="deploy" depends="build" description="Deploy the built Dart tests">
« no previous file with comments | « editor/build/promote.py ('k') | editor/tools/plugins/com.google.dart.tools.core/META-INF/MANIFEST.MF » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698