Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: editor/build/build.py

Issue 11638015: Fix 2 failing tests on windows. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/build/build.py
===================================================================
--- editor/build/build.py (revision 16302)
+++ editor/build/build.py (working copy)
@@ -17,6 +17,7 @@
import hashlib
from os.path import join
+from xml.dom.minidom import parseString
BUILD_OS = None
DART_PATH = None
@@ -402,9 +403,26 @@
revision, options.name, buildroot, buildout,
editorpath, buildos,
extra_artifacts=extra_artifacts)
+
+ #<testsuite errors="0" failures="1" name="com.google.dart.tools.core_test"
+ # tests="740" time="40.713">
+ testResults = parseString(open(join(buildout, 'test-results.xml')).read())
+ testsuite = testResults.documentElement
+ if testsuite.getAttribute("errors") != "0":
+ junit_status = 1
+ if testsuite.getAttribute("failures") != "0":
+ junit_status = 1
+
+ print "\n%s: %s tests, %s errors, %s failures (time: %s)\n" % (
+ testsuite.getAttribute("name"),
+ testsuite.getAttribute("tests"),
+ testsuite.getAttribute("errors"),
+ testsuite.getAttribute("failures"),
+ testsuite.getAttribute("time"))
+
properties = ReadPropertyFile(buildos, ant_property_file.name)
- if buildos:
- UploadTestHtml(buildout, to_bucket, revision, buildos, gsu)
+ #if buildos:
+ # UploadTestHtml(buildout, to_bucket, revision, buildos, gsu)
danrubel 2012/12/19 14:55:32 Should we continue to upload the test results as a
devoncarew 2012/12/19 17:35:13 I'd prefer no - it makes our build simpler to not
if junit_status:
if properties['build.runtime']:
#if there is a build.runtime and the status is not

Powered by Google App Engine
This is Rietveld 408576698