Fix 2 failing tests on windows.

editor/build/build.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import glob
 import optparse
 import os
 import re
 import shutil
 import subprocess
 import sys
 import tempfile
 import gsutil
 import ziputils
 import hashlib
 
 from os.path import join
+from xml.dom.minidom import parseString
 
 BUILD_OS = None
 DART_PATH = None
 TOOLS_PATH = None
 
 GSU_PATH_REV = None
 GSU_PATH_LATEST = None
 GSU_API_DOCS_PATH = None
 GSU_API_DOCS_BUCKET = 'gs://dartlang-api-docs'
 
@@ skipping 365 matching lines @@
     if status:
       return status
 
     if not build_skip_tests:
       PrintSeparator('Running the tests')
       junit_status = ant.RunAnt('../com.google.dart.tools.tests.feature_releng',
                               'buildTests.xml',
                               revision, options.name, buildroot, buildout,
                               editorpath, buildos,
                               extra_artifacts=extra_artifacts)
+      
+      #<testsuite errors="0" failures="1" name="com.google.dart.tools.core_test"
+      #   tests="740" time="40.713">
+      testResults = parseString(open(join(buildout, 'test-results.xml')).read())
+      testsuite = testResults.documentElement
+      if testsuite.getAttribute("errors") != "0":
+        junit_status = 1
+      if testsuite.getAttribute("failures") != "0":
+        junit_status = 1
+      
+      print "\n%s: %s tests, %s errors, %s failures (time: %s)\n" % (
+          testsuite.getAttribute("name"),
+          testsuite.getAttribute("tests"),
+          testsuite.getAttribute("errors"),
+          testsuite.getAttribute("failures"),
+          testsuite.getAttribute("time"))
+      
       properties = ReadPropertyFile(buildos, ant_property_file.name)
-      if buildos:
-        UploadTestHtml(buildout, to_bucket, revision, buildos, gsu)
+      #if buildos:
+      #  UploadTestHtml(buildout, to_bucket, revision, buildos, gsu)

[danrubel, 2012/12/19 14:55:32]

Should we continue to upload the test results as an HTML report?

[devoncarew, 2012/12/19 17:35:13]

I'd prefer no - it makes our build simpler to not do it. We get the same value
from the stdout output on the buildbots. Otherwise we have to have code to write
the html output, code to copy it up to GS, code in promote to delete the
directories...

       if junit_status:
         if properties['build.runtime']:
           #if there is a build.runtime and the status is not
           #zero see if there are any *.log entries
           PrintErrorLog(properties['build.runtime'])
     else:
       junit_status = 0
 
     if buildos:
       _InstallArtifacts(buildout, buildos, extra_artifacts)
@@ skipping 638 matching lines @@
   """delete the given file - do not re-throw any exceptions that occur"""
   if os.path.exists(f):
     try:
       os.remove(f)
     except OSError:
       print 'error deleting %s' % f
 
 
 if __name__ == '__main__':
   sys.exit(main())