Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1163793002: Fix bogus insertion of filler in LO-space by String#replace. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bogus insertion of filler in LO-space by String#replace. R=hpayer@chromium.org TEST=mjsunit/regress/regress-crbug-493779 BUG=chromium:493779 LOG=N Committed: https://crrev.com/d207fcef664c63bd9337f13052c5315bbeaafd7e Cr-Commit-Position: refs/heads/master@{#28727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/runtime/runtime-regexp.cc View 1 chunk +5 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-493779.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-01 09:09:12 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 6 months ago (2015-06-01 13:33:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163793002/1
5 years, 6 months ago (2015-06-01 13:34:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 13:36:07 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 13:36:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d207fcef664c63bd9337f13052c5315bbeaafd7e
Cr-Commit-Position: refs/heads/master@{#28727}

Powered by Google App Engine
This is Rietveld 408576698