Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1163733004: Switch HttpStreamFactoryTest to using SequencedSocketData. (Closed)

Created:
5 years, 6 months ago by mmenke
Modified:
5 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch HttpStreamFactoryTest to using SequencedSocketData. Some were using DeterministicSocketData instead. BUG=492685 Committed: https://crrev.com/6429ac9b559cd357d090edc6a191e1b556b930dc Cr-Commit-Position: refs/heads/master@{#333125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M net/http/http_stream_factory_impl_unittest.cc View 2 chunks +12 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mmenke
After this and one more, we'll just have WebSocket tests, and three test fixtures which ...
5 years, 6 months ago (2015-06-05 19:12:26 UTC) #2
Ryan Hamilton
lgtm AWESOME! So Exciting!
5 years, 6 months ago (2015-06-05 20:26:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163733004/1
5 years, 6 months ago (2015-06-05 20:30:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 20:49:12 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:50:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6429ac9b559cd357d090edc6a191e1b556b930dc
Cr-Commit-Position: refs/heads/master@{#333125}

Powered by Google App Engine
This is Rietveld 408576698