media/cdm/cenc_utils.cc - Issue 1163713007: Use 'pssh' data to determine key_id properly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cdm/cenc_utils.cc

Issue 1163713007: Use 'pssh' data to determine key_id properly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/cdm/cenc_utils.cc

diff --git a/media/cdm/cenc_utils.cc b/media/cdm/cenc_utils.cc

index 495a6f2fb2f6eba1d741a2dbf1c83bbd22ad5c00..1e33cca361337898f0371281632af05e8b7d0759 100644

--- a/media/cdm/cenc_utils.cc

+++ b/media/cdm/cenc_utils.cc

@@ -89,12 +89,8 @@ bool GetKeyIdsForCommonSystemId(const std::vector<uint8_t>& input,

}

- // No matching 'pssh' box found.

- // TODO(jrummell): This should return true only if there was at least one

- // key ID present. However, numerous test files don't contain the 'pssh' box

- // for Common Format, so no keys are found. http://crbug.com/460308

key_ids->swap(result);

- return true;

+ return key_ids->size() > 0;

}

bool GetPsshData(const std::vector<uint8_t>& input,

« no previous file with comments | « media/cdm/cenc_utils.h ('k') | media/cdm/cenc_utils_unittest.cc » ('j') | no next file with comments »