Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: media/cdm/cenc_utils.h

Issue 1163713007: Use 'pssh' data to determine key_id properly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/cdm/cenc_utils.cc » ('j') | media/cdm/cenc_utils_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cdm/cenc_utils.h
diff --git a/media/cdm/cenc_utils.h b/media/cdm/cenc_utils.h
index ec85fb34e8b2f36728ada7438708c2eaf741d8be..23d6c131408c86e77f85bee08437faaac93b7096 100644
--- a/media/cdm/cenc_utils.h
+++ b/media/cdm/cenc_utils.h
@@ -21,10 +21,6 @@ MEDIA_EXPORT bool ValidatePsshInput(const std::vector<uint8_t>& input);
// more concatenated 'pssh' boxes. If |input| looks valid, then true is
// returned and |key_ids| is updated to contain the values found. Otherwise
// return false.
-// TODO(jrummell): This returns true if no Common SystemID 'pssh' boxes are
-// found, or are included but don't contain any key IDs. This should be
-// fixed once the test files are updated to include correct 'pssh' boxes.
-// http://crbug.com/460308
MEDIA_EXPORT bool GetKeyIdsForCommonSystemId(const std::vector<uint8_t>& input,
ddorwin 2015/06/04 19:57:17 Are there any call sites that were checking for th
jrummell 2015/06/15 22:22:09 Nope. The only caller (other than tests) is aes_de
KeyIdList* key_ids);
« no previous file with comments | « no previous file | media/cdm/cenc_utils.cc » ('j') | media/cdm/cenc_utils_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698