Add check for device provisioning

Add check for device provisioning

Extend device_status_check to look for incorrectly setup devices.
BUG=165981
NOTRY=true

Committed:  http://src.chromium.org/viewvc/chrome?view=rev&revision=174343

[Isaac (away), 2012-12-20 21:09:51]

This was the issue from the new Android Tests bot.  Adding a check to prevent
future issues like this.

[boliu, 2012-12-20 21:15:54]

On 2012/12/20 21:09:51, Isaac wrote:
> This was the issue from the new Android Tests bot.  Adding a check to prevent
> future issues like this.

I tried applying and running on my "unprovisioned" local device and it didn't
complain. My guess is run_instrumentation_tests.py adds local.prop?

[Yaron, 2012-12-20 21:15:56]

lgtm

We discussed some other changes we could do to shore up tests Such as in:
https://codereview.chromium.org/11642050/

Filed 167141 to track

[boliu, 2012-12-20 21:23:16]

On 2012/12/20 21:15:54, boliu wrote:
> On 2012/12/20 21:09:51, Isaac wrote:
> > This was the issue from the new Android Tests bot.  Adding a check to
prevent
> > future issues like this.
> 
> I tried applying and running on my "unprovisioned" local device and it didn't
> complain. My guess is run_instrumentation_tests.py adds local.prop?

Oh, it was only added when run_instrumentation_tests was run under adb root.
lgtm since you said none of the upstream bots run with adb root.

[Isaac (away), 2012-12-20 21:26:25]

Do either if you have a better suggestion for a setting that is set by our
provisioning script and queryable from non-root?  I could check for a specific
entry in local.prop instead of that the file exists.

 This is the provisioning we're using btw.  It came from our downstream script.

http://chromegw/viewvc/chrome-internal/trunk/tools/build/scripts/slave/androi...

[boliu, 2012-12-20 21:34:29]

On 2012/12/20 21:26:25, Isaac wrote:
> Do either if you have a better suggestion for a setting that is set by our
> provisioning script and queryable from non-root?  I could check for a specific
> entry in local.prop instead of that the file exists.
> 
>  This is the provisioning we're using btw.  It came from our downstream
script.
> 
>
http://chromegw/viewvc/chrome-internal/trunk/tools/build/scripts/slave/androi...

how about
adb shell getprop ro.setupwizard.mode

I'd like to check for the lock screen ones but I don't see it in the list when
running getprop with no arguments.

[Isaac (away), 2012-12-20 21:38:13]

Yes, lockscreen is a system setting so it's not in getprop.

[Isaac (away), 2012-12-20 21:38:41]

I like the setupmode though, will switch to that.

[commit-bot: I haz the power, 2012-12-21 03:37:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/11637046/8001