Fix Windows XP process handling.

runtime/bin/process_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <process.h>
 
 #include "bin/builtin.h"
 #include "bin/process.h"
 #include "bin/eventhandler.h"
 #include "bin/log.h"
@@ skipping 301 matching lines @@
       Log::PrintErr("FormatMessage failed %d\n", GetLastError());
     }
     _snwprintf(message, kMaxMessageLength, L"OS Error %d", error_code);
   }
   message[kMaxMessageLength - 1] = '\0';
   *os_error_message = StringUtils::WideToUtf8(message);
   return error_code;
 }
 
 
+typedef BOOL (WINAPI *InitProcThreadAttrListFn)(
+    LPPROC_THREAD_ATTRIBUTE_LIST, DWORD, DWORD, PSIZE_T);
+
+typedef BOOL (WINAPI *UpdateProcThreadAttrFn)(
+    LPPROC_THREAD_ATTRIBUTE_LIST, DWORD, DWORD_PTR,
+    PVOID, SIZE_T, PVOID, PSIZE_T);
+
+typedef VOID (WINAPI *DeleteProcThreadAttrListFn)(
+     LPPROC_THREAD_ATTRIBUTE_LIST);
+
+
+static InitProcThreadAttrListFn init_proc_thread_attr_list = NULL;
+static UpdateProcThreadAttrFn update_proc_thread_attr = NULL;
+static DeleteProcThreadAttrListFn delete_proc_thread_attr_list = NULL;
+
+
+static bool EnsureInitialized() {
+  HMODULE kernel32_module = GetModuleHandle(L"kernel32.dll");
+  if (init_proc_thread_attr_list == NULL) {

[Søren Gjesse, 2012/12/19 09:51:51]

On XP this will try to load InitializeProcThreadAttributeList for every call to
EnsureInitialized. Maybe thats not a big deal.

[Mads Ager (google), 2012/12/19 10:00:54]

Fixed as part of the below.

+    init_proc_thread_attr_list = reinterpret_cast<InitProcThreadAttrListFn>(

[Søren Gjesse, 2012/12/19 09:51:51]

As this could be called by several threads at the same time we should probably
use some locking . On 32-bit this is not needed, but I am not sure about 64-bit.
Of cause it will be one in a million...

[Mads Ager (google), 2012/12/19 10:00:54]

Thanks. I put in locking.

+        GetProcAddress(kernel32_module, "InitializeProcThreadAttributeList"));
+    if (init_proc_thread_attr_list == NULL) return false;
+    update_proc_thread_attr =
+        reinterpret_cast<UpdateProcThreadAttrFn>(
+            GetProcAddress(kernel32_module, "UpdateProcThreadAttribute"));
+    if (update_proc_thread_attr == NULL) return false;
+    delete_proc_thread_attr_list = reinterpret_cast<DeleteProcThreadAttrListFn>(
+        reinterpret_cast<DeleteProcThreadAttrListFn>(
+            GetProcAddress(kernel32_module, "DeleteProcThreadAttributeList")));
+    return delete_proc_thread_attr_list != NULL;
+  }
+  return true;
+}
+
+
 int Process::Start(const char* path,
                    char* arguments[],
                    intptr_t arguments_length,
                    const char* working_directory,
                    char* environment[],
                    intptr_t environment_length,
                    intptr_t* in,
                    intptr_t* out,
                    intptr_t* err,
                    intptr_t* id,
@@ skipping 61 matching lines @@
 
   // Setup info structures.
   STARTUPINFOEXW startup_info;
   ZeroMemory(&startup_info, sizeof(startup_info));
   startup_info.StartupInfo.cb = sizeof(startup_info);
   startup_info.StartupInfo.hStdInput = stdin_handles[kReadHandle];
   startup_info.StartupInfo.hStdOutput = stdout_handles[kWriteHandle];
   startup_info.StartupInfo.hStdError = stderr_handles[kWriteHandle];
   startup_info.StartupInfo.dwFlags = STARTF_USESTDHANDLES;
 
-  // Setup the handles to inherit. We only want to inherit the three handles
-  // for stdin, stdout and stderr.
-  SIZE_T size = 0;
-  // The call to determine the size of an attribute list always fails with
-  // ERROR_INSUFFICIENT_BUFFER and that error should be ignored.
-  if (!InitializeProcThreadAttributeList(NULL, 1, 0, &size) &&
-      GetLastError() != ERROR_INSUFFICIENT_BUFFER) {
-    int error_code = SetOsErrorMessage(os_error_message);
-    CloseProcessPipes(
-        stdin_handles, stdout_handles, stderr_handles, exit_handles);
-    return error_code;
-  }
-  LPPROC_THREAD_ATTRIBUTE_LIST attribute_list =
-      reinterpret_cast<LPPROC_THREAD_ATTRIBUTE_LIST>(malloc(size));
-  ZeroMemory(attribute_list, size);
-  if (!InitializeProcThreadAttributeList(attribute_list, 1, 0, &size)) {
-    int error_code = SetOsErrorMessage(os_error_message);
-    CloseProcessPipes(
-        stdin_handles, stdout_handles, stderr_handles, exit_handles);
-    free(attribute_list);
-    return error_code;
-  }
-  static const int kNumInheritedHandles = 3;
-  HANDLE inherited_handles[kNumInheritedHandles] =
-      { stdin_handles[kReadHandle],
-        stdout_handles[kWriteHandle],
-        stderr_handles[kWriteHandle] };
-  if (!UpdateProcThreadAttribute(attribute_list,
+  LPPROC_THREAD_ATTRIBUTE_LIST attribute_list = NULL;
+
+  bool supports_proc_thread_attr_lists = EnsureInitialized();
+  if (supports_proc_thread_attr_lists) {
+    // Setup the handles to inherit. We only want to inherit the three handles
+    // for stdin, stdout and stderr.
+    SIZE_T size = 0;
+    // The call to determine the size of an attribute list always fails with
+    // ERROR_INSUFFICIENT_BUFFER and that error should be ignored.
+    if (!init_proc_thread_attr_list(NULL, 1, 0, &size) &&
+        GetLastError() != ERROR_INSUFFICIENT_BUFFER) {
+      int error_code = SetOsErrorMessage(os_error_message);
+      CloseProcessPipes(
+          stdin_handles, stdout_handles, stderr_handles, exit_handles);
+      return error_code;
+    }
+    attribute_list =
+        reinterpret_cast<LPPROC_THREAD_ATTRIBUTE_LIST>(malloc(size));
+    ZeroMemory(attribute_list, size);
+    if (!init_proc_thread_attr_list(attribute_list, 1, 0, &size)) {
+      int error_code = SetOsErrorMessage(os_error_message);
+      CloseProcessPipes(
+          stdin_handles, stdout_handles, stderr_handles, exit_handles);
+      free(attribute_list);
+      return error_code;
+    }
+    static const int kNumInheritedHandles = 3;
+    HANDLE inherited_handles[kNumInheritedHandles] =
+        { stdin_handles[kReadHandle],
+          stdout_handles[kWriteHandle],
+          stderr_handles[kWriteHandle] };
+    if (!update_proc_thread_attr(attribute_list,
                                  0,
                                  PROC_THREAD_ATTRIBUTE_HANDLE_LIST,
                                  inherited_handles,
                                  kNumInheritedHandles * sizeof(HANDLE),
                                  NULL,
                                  NULL)) {
-    DeleteProcThreadAttributeList(attribute_list);
-    int error_code = SetOsErrorMessage(os_error_message);
-    CloseProcessPipes(
-        stdin_handles, stdout_handles, stderr_handles, exit_handles);
-    free(attribute_list);
-    return error_code;
+      delete_proc_thread_attr_list(attribute_list);
+      int error_code = SetOsErrorMessage(os_error_message);
+      CloseProcessPipes(
+          stdin_handles, stdout_handles, stderr_handles, exit_handles);
+      free(attribute_list);
+      return error_code;
+    }
+    startup_info.lpAttributeList = attribute_list;
   }
-  startup_info.lpAttributeList = attribute_list;
 
   PROCESS_INFORMATION process_info;
   ZeroMemory(&process_info, sizeof(process_info));
 
   // Transform input strings to system format.
   const wchar_t* system_path = StringUtils::Utf8ToWide(path);
   wchar_t** system_arguments = new wchar_t*[arguments_length];
   for (int i = 0; i < arguments_length; i++) {
      system_arguments[i] = StringUtils::Utf8ToWide(arguments[i]);
   }
 
   // Compute command-line length.
   int command_line_length = wcslen(system_path);
   for (int i = 0; i < arguments_length; i++) {
     command_line_length += wcslen(system_arguments[i]);
   }
   // Account for null termination and one space per argument.
   command_line_length += arguments_length + 1;
   static const int kMaxCommandLineLength = 32768;
   if (command_line_length > kMaxCommandLineLength) {
     int error_code = SetOsErrorMessage(os_error_message);
     CloseProcessPipes(
         stdin_handles, stdout_handles, stderr_handles, exit_handles);
     free(const_cast<wchar_t*>(system_path));
     for (int i = 0; i < arguments_length; i++) free(system_arguments[i]);
     delete[] system_arguments;
-    DeleteProcThreadAttributeList(attribute_list);
-    free(attribute_list);
+    if (supports_proc_thread_attr_lists) {
+      delete_proc_thread_attr_list(attribute_list);
+      free(attribute_list);
+    }
     return error_code;
   }
 
   // Put together command-line string.
   wchar_t* command_line = new wchar_t[command_line_length];
   int len = 0;
   int remaining = command_line_length;
   int written = _snwprintf(command_line + len, remaining, L"%s", system_path);
   len += written;
   remaining -= written;
@@ skipping 64 matching lines @@
                                reinterpret_cast<STARTUPINFOW*>(&startup_info),
                                &process_info);
 
   // Deallocate command-line and environment block strings.
   delete[] command_line;
   delete[] environment_block;
   if (system_working_directory != NULL) {
     free(const_cast<wchar_t*>(system_working_directory));
   }
 
-  DeleteProcThreadAttributeList(attribute_list);
-  free(attribute_list);
+  if (supports_proc_thread_attr_lists) {
+    delete_proc_thread_attr_list(attribute_list);
+    free(attribute_list);
+  }
 
   if (result == 0) {
     int error_code = SetOsErrorMessage(os_error_message);
     CloseProcessPipes(
         stdin_handles, stdout_handles, stderr_handles, exit_handles);
     return error_code;
   }
 
   ProcessInfoList::AddProcess(process_info.dwProcessId,
                               process_info.hProcess,
@@ skipping 37 matching lines @@
 
 
 void Process::TerminateExitCodeHandler() {
   // Nothing needs to be done on Windows.
 }
 
 
 intptr_t Process::CurrentProcessId() {
   return static_cast<intptr_t>(GetCurrentProcessId());
 }