Introducing GlobalDictionary, a backing store for global objects.

Introducing GlobalDictionary, a backing store for global objects.

This updates Dictionary classes hierarchy and introduces GlobalDictionary class but it is not used yet.

Committed: https://crrev.com/6c6b425dea21775c7813ccda3b00246aa018e7fa
Cr-Commit-Position: refs/heads/master@{#28732}

[Igor Sheludko, 2015-05-29 16:34:54]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2015-05-29 16:34:55]

PTAL

[Igor Sheludko, 2015-05-29 18:42:35]

Patchset #4 (id:60001) has been deleted

[Igor Sheludko, 2015-05-29 18:47:29]

Patchset #4 (id:80001) has been deleted

[Igor Sheludko, 2015-06-01 13:58:52]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Jakob Kummerow, 2015-06-01 14:33:30]

LGTM with nits.

https://codereview.chromium.org/1163673003/diff/100001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1163673003/diff/100001/src/objects-inl.h#newc...
src/objects-inl.h:3389: CAST_ACCESSOR(GlobalDictionary)
nit: move before GlobalObject to maintain alpha-sorting

https://codereview.chromium.org/1163673003/diff/100001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1163673003/diff/100001/src/objects.cc#newcode...
src/objects.cc:16255: PropertyDetails details = DetailsAt(i);
nit: while you're here, please fix indentation for the entire function.

https://codereview.chromium.org/1163673003/diff/100001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1163673003/diff/100001/src/objects.h#newcode3720
src/objects.h:3720: 
nit: no double empty line required here

[Igor Sheludko, 2015-06-01 14:59:36]

https://codereview.chromium.org/1163673003/diff/100001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1163673003/diff/100001/src/objects-inl.h#newc...
src/objects-inl.h:3389: CAST_ACCESSOR(GlobalDictionary)
On 2015/06/01 14:33:29, Jakob wrote:
> nit: move before GlobalObject to maintain alpha-sorting

Done.

https://codereview.chromium.org/1163673003/diff/100001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1163673003/diff/100001/src/objects.cc#newcode...
src/objects.cc:16255: PropertyDetails details = DetailsAt(i);
On 2015/06/01 14:33:29, Jakob wrote:
> nit: while you're here, please fix indentation for the entire function.

I did that in one of the follow-up CLs. I'd prefer to leave it as is for now to
avoid rebasing mess.

https://codereview.chromium.org/1163673003/diff/100001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/1163673003/diff/100001/src/objects.h#newcode3720
src/objects.h:3720: 
On 2015/06/01 14:33:29, Jakob wrote:
> nit: no double empty line required here

Done.

[Igor Sheludko, 2015-06-01 14:59:45]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2015-06-01 14:59:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1163673003/#ps120001
(title: "Addressing comments")

[commit-bot: I haz the power, 2015-06-01 14:59:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163673003/120001

[commit-bot: I haz the power, 2015-06-01 15:43:33]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2015-06-01 15:43:51]

Patchset 5 (id:??) landed as
https://crrev.com/6c6b425dea21775c7813ccda3b00246aa018e7fa
Cr-Commit-Position: refs/heads/master@{#28732}