Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 1163653005: Remove deprecated APIs from WebDataConsumerHandle. (Closed)

Created:
4 years, 11 months ago by yhirano
Modified:
4 years, 10 months ago
Reviewers:
hiroshige, tkent
CC:
blink-reviews, tyoshino+watch_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@reader-interface
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove deprecated APIs from WebDataConsumerHandle. We are added WebDataConsumerHandle::Reader and deprecated *read functions in a previous CL[1]. In this CL we make XHR use the new API and remove the deprecated APIs. 1: https://codereview.chromium.org/1164493008/ BUG=480746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197170

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -36 lines) Patch
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M public/platform/WebDataConsumerHandle.h View 1 2 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
yhirano
This CL depends on https://codereview.chromium.org/1164493008/.
4 years, 10 months ago (2015-06-08 04:37:57 UTC) #3
hiroshige
Please mention in the CL description that we also remove uses of the deprecated APIs ...
4 years, 10 months ago (2015-06-09 04:16:52 UTC) #4
yhirano
On 2015/06/09 04:16:52, hiroshige wrote: > Please mention in the CL description that we also ...
4 years, 10 months ago (2015-06-09 05:49:40 UTC) #5
yhirano
+tkent for OWNER review.
4 years, 10 months ago (2015-06-15 02:13:52 UTC) #7
tkent
lgtm
4 years, 10 months ago (2015-06-15 03:27:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163653005/40001
4 years, 10 months ago (2015-06-15 03:27:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163653005/60001
4 years, 10 months ago (2015-06-15 11:51:35 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/38318)
4 years, 10 months ago (2015-06-15 12:14:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163653005/60001
4 years, 10 months ago (2015-06-16 09:04:28 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/66799)
4 years, 10 months ago (2015-06-16 10:40:16 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163653005/60001
4 years, 10 months ago (2015-06-16 11:37:28 UTC) #23
commit-bot: I haz the power
4 years, 10 months ago (2015-06-16 12:27:36 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197170

Powered by Google App Engine
This is Rietveld 408576698