Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1163633003: Port DrawerHeader to fn2 world. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
jackson, eseidel
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, abarth-chromium
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Port DrawerHeader to fn2 world. This includes making SizedBox default to infinite size, and making Container default to containing one infinite-sized SizedBox. That way, you can use an empty Container as a spacer in a flex box. The rendering doesn't quite work, because of a bug in flex whereby it doesn't shrink-wrap its contents in the cross-direction, it fills the parent. Collin is on that. R=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/8019c6f09df325f8d389954ff05f549cf01bf178

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : remove sky. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -32 lines) Patch
M sky/examples/stocks2/lib/stock_app.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/drawer_header.dart View 1 2 3 4 5 1 chunk +33 lines, -28 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 2 chunks +8 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/theme2/view_configuration.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eseidel
lgtm https://codereview.chromium.org/1163633003/diff/80001/sky/sdk/lib/framework/components2/drawer_header.dart File sky/sdk/lib/framework/components2/drawer_header.dart (right): https://codereview.chromium.org/1163633003/diff/80001/sky/sdk/lib/framework/components2/drawer_header.dart#newcode26 sky/sdk/lib/framework/components2/drawer_header.dart:26: color: const sky.Color(0xFFD1D9E1), sky. https://codereview.chromium.org/1163633003/diff/80001/sky/sdk/lib/framework/components2/drawer_header.dart#newcode39 sky/sdk/lib/framework/components2/drawer_header.dart:39: desiredSize: sky.Size.infinite ...
5 years, 6 months ago (2015-06-08 17:55:21 UTC) #2
jackson
lgtm lgtm
5 years, 6 months ago (2015-06-08 17:55:54 UTC) #4
Hixie
5 years, 6 months ago (2015-06-08 18:00:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
8019c6f09df325f8d389954ff05f549cf01bf178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698