tools/cr/cr/actions/ninja.py - Issue 116363002: [cr tool] Fixing import problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/cr/cr/actions/ninja.py

Issue 116363002: [cr tool] Fixing import problems (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change the place we hook late detection from Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/cr/cr/actions/ninja.py

diff --git a/tools/cr/cr/actions/ninja.py b/tools/cr/cr/actions/ninja.py

index 404e6caea26e11360bf1b874e72c8de38f3fd697..fda217a6d9b27fb22f2f0e1091f34bae3e2fbd2e 100644

--- a/tools/cr/cr/actions/ninja.py

+++ b/tools/cr/cr/actions/ninja.py

@@ -77,10 +77,8 @@ class NinjaBuilder(cr.Builder):

return self._targets

@classmethod

- def DetectNinja(cls):

+ def ClassInit(cls):

# TODO(iancottrell): If we can't detect ninja, we should be disabled.

ninja_binaries = cr.Host.SearchPath('ninja')

if ninja_binaries:

cls.DETECTED.Set(NINJA_BINARY=ninja_binaries[0])

-NinjaBuilder.DetectNinja()

« no previous file with comments | « tools/cr/cr/actions/gdb.py ('k') | tools/cr/cr/commands/sync.py » ('j') | no next file with comments »