Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 11636058: Make hyphen compile on Win64 (Closed)

Created:
8 years ago by jschuh
Modified:
8 years ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Visibility:
Public.

Description

Make hyphen compile on Win64 BUG=166496 BUG=167187 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174467

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/hyphen/hyphen.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jschuh
8 years ago (2012-12-21 04:26:16 UTC) #1
groby-ooo-7-16
lgtm
8 years ago (2012-12-21 22:07:36 UTC) #2
groby-ooo-7-16
8 years ago (2012-12-21 22:07:59 UTC) #3
https://codereview.chromium.org/11636058/diff/1/third_party/hyphen/hyphen.gyp
File third_party/hyphen/hyphen.gyp (right):

https://codereview.chromium.org/11636058/diff/1/third_party/hyphen/hyphen.gyp...
third_party/hyphen/hyphen.gyp:30: # TODO(jschuh): Bug 167187. Fix this.
nit: http://crbug.com/167187

Powered by Google App Engine
This is Rietveld 408576698