AutofillPopupController clarifications + simplifications.

chrome/browser/ui/autofill/autofill_dialog_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
 
 #include "base/logging.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 378 matching lines @@
                           popup_ids);
 }
 
 void AutofillDialogController::FocusMoved() {
   if (popup_controller_) {
     popup_controller_->Hide();
     ControllerDestroyed();
   }
 }
 
-void AutofillDialogController::SelectAutofillSuggestion(int unique_id) {
+void AutofillDialogController::DidSelectSuggestion(int identifier) {
   // TODO(estade): implement.
 }
 
-bool AutofillDialogController::DidAcceptAutofillSuggestion(
-    const string16& value,
-    int unique_id,
-    unsigned index) {
-  const PersonalDataManager::GUIDPair& pair = popup_guids_[unique_id];
+void AutofillDialogController::DidAcceptSuggestion(const string16& value,
+                                                   int identifier) {
+  const PersonalDataManager::GUIDPair& pair = popup_guids_[identifier];
   // TODO(estade): need to use the variant, |pair.second|.
   AutofillProfile* profile = GetManager()->GetProfileByGUID(pair.first);
   // TODO(estade): we shouldn't let this happen.
   if (!profile)
-    return false;
+    return;
 
   // TODO(estade): implement for all sections.
   FillInputFromFormGroup(profile, &requested_billing_fields_);
   view_->UpdateSection(SECTION_BILLING);
 
   // TODO(estade): not sure why it's necessary to do this explicitly.
   popup_controller_->Hide();
   ControllerDestroyed();
-  return true;
 }
 
-void AutofillDialogController::RemoveAutocompleteEntry(const string16& value) {
+void AutofillDialogController::RemoveSuggestion(const string16& value,
+                                                int identifier) {
   // TODO(estade): implement.
 }
 
-void AutofillDialogController::RemoveAutofillProfileOrCreditCard(
-    int unique_id) {
-  // TODO(estade): implement.
-}
-
 void AutofillDialogController::ClearPreviewedForm() {
   // TODO(estade): implement.
 }
 
 void AutofillDialogController::ControllerDestroyed() {
   popup_controller_ = NULL;
 }
 
 void AutofillDialogController::GenerateComboboxModels() {
   PersonalDataManager* manager = GetManager();
@@ skipping 105 matching lines @@
 
   NOTREACHED();
   return NULL;
 }
 
 PersonalDataManager* AutofillDialogController::GetManager() {
   return PersonalDataManagerFactory::GetForProfile(profile_);
 }
 
 }  // namespace autofill