AutofillPopupController clarifications + simplifications.

chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/android/autofill/autofill_popup_view_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "chrome/browser/ui/android/window_android_helper.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller.h"
@@ skipping 37 matching lines @@
                                        controller_->element_bounds().x(),
                                        controller_->element_bounds().y(),
                                        controller_->element_bounds().width(),
                                        controller_->element_bounds().height());
 
   // We need an array of AutofillSuggestion.
   ScopedJavaLocalRef<jclass> autofill_suggestion_clazz =
       base::android::GetClass(env,
           "org/chromium/chrome/browser/autofill/AutofillSuggestion");
   ScopedJavaLocalRef<jobjectArray> data_array(env,
-      env->NewObjectArray(controller_->autofill_values().size(),
+      env->NewObjectArray(controller_->names().size(),
                           autofill_suggestion_clazz.obj(), NULL));
   base::android::CheckException(env);
-  for (size_t i = 0; i < controller_->autofill_values().size(); ++i) {
-    ScopedJavaLocalRef<jstring> value =
+  for (size_t i = 0; i < controller_->names().size(); ++i) {
+    ScopedJavaLocalRef<jstring> name =
         base::android::ConvertUTF16ToJavaString(
-            env, controller_->autofill_values()[i]);
-    ScopedJavaLocalRef<jstring> label =
+            env, controller_->names()[i]);
+    ScopedJavaLocalRef<jstring> subtext =
         base::android::ConvertUTF16ToJavaString(
-            env, controller_->autofill_labels()[i]);
-    int unique_id = controller_->autofill_unique_ids()[i];
+            env, controller_->subtexts()[i]);
+    int identifier = controller_->identifiers()[i];
     ScopedJavaLocalRef<jobject> data =
         Java_AutofillPopupGlue_createAutofillSuggestion(env,
-                                                        value.obj(),
-                                                        label.obj(),
-                                                        unique_id);
+                                                        name.obj(),
+                                                        subtext.obj(),
+                                                        identifier);
     env->SetObjectArrayElement(data_array.obj(), i, data.obj());
     base::android::CheckException(env);
   }
 
   Java_AutofillPopupGlue_show(env, java_object_.obj(), data_array.obj());
 }
 
 void AutofillPopupViewAndroid::SuggestionSelected(JNIEnv* env,
                                                   jobject obj,
                                                   jint list_index,
-                                                  jstring value,
-                                                  jint unique_id) {
-  string16 value_utf16 = base::android::ConvertJavaStringToUTF16(env, value);
-  controller_->AcceptAutofillSuggestion(value_utf16,
-                                        unique_id,
-                                        list_index);
+                                                  jstring /*name*/,
+                                                  jint /*identifier*/) {
+  controller_->AcceptSuggestion(list_index);
 }
 
 void AutofillPopupViewAndroid::Dismissed(JNIEnv* env, jobject obj) {
   delete this;
 }
 
 void AutofillPopupViewAndroid::InvalidateRow(size_t) {}
 
 // static
 bool AutofillPopupViewAndroid::RegisterAutofillPopupViewAndroid(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 // static
 AutofillPopupView* AutofillPopupView::Create(
     AutofillPopupController* controller) {
   return new AutofillPopupViewAndroid(controller);
 }