AutofillPopupController clarifications + simplifications.

chrome/browser/autofill/autofill_external_delegate_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/autofill/autofill_manager.h"
 #include "chrome/browser/autofill/test_autofill_external_delegate.h"
 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
 #include "chrome/browser/ui/autofill/autofill_popup_view.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 17 matching lines @@
 namespace {
 
 class MockAutofillExternalDelegate : public AutofillExternalDelegate {
  public:
   explicit MockAutofillExternalDelegate(content::WebContents* web_contents)
       : AutofillExternalDelegate(
             web_contents,
             AutofillManager::FromWebContents(web_contents)) {}
   ~MockAutofillExternalDelegate() {}
 
-  virtual void SelectAutofillSuggestion(int unique_id) OVERRIDE {}
+  virtual void DidSelectSuggestion(int unique_id) OVERRIDE {}
 
   virtual void ClearPreviewedForm() OVERRIDE {}
 
   AutofillPopupControllerImpl* GetController() {
     return controller();
   }
 
   MOCK_METHOD0(HideAutofillPopup, void());
 };
 
@@ skipping 91 matching lines @@
                        MAYBE_CloseWidgetAndNoLeaking) {
   EXPECT_CALL(*autofill_external_delegate_,
               HideAutofillPopup()).Times(AtLeast(1));
 
   autofill::GenerateTestAutofillPopup(autofill_external_delegate_.get());
 
   // Delete the view from under the delegate to ensure that the
   // delegate and the controller can handle the popup getting deleted elsewhere.
   autofill_external_delegate_->GetController()->view()->Hide();
 }