Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Side by Side Diff: chrome/browser/autofill/autofill_external_delegate.h

Issue 11636040: AutofillPopupController clarifications + simplifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new workstation Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_external_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_ 6 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 29 matching lines...) Expand all
40 public content::NotificationObserver, 40 public content::NotificationObserver,
41 public AutofillPopupDelegate { 41 public AutofillPopupDelegate {
42 public: 42 public:
43 // Creates an AutofillExternalDelegate and attaches it to the specified 43 // Creates an AutofillExternalDelegate and attaches it to the specified
44 // contents; the second argument is an AutofillManager managing Autofill for 44 // contents; the second argument is an AutofillManager managing Autofill for
45 // that WebContents. 45 // that WebContents.
46 static void CreateForWebContentsAndManager(content::WebContents* web_contents, 46 static void CreateForWebContentsAndManager(content::WebContents* web_contents,
47 AutofillManager* autofill_manager); 47 AutofillManager* autofill_manager);
48 48
49 // AutofillPopupDelegate implementation. 49 // AutofillPopupDelegate implementation.
50 virtual void SelectAutofillSuggestion(int unique_id) OVERRIDE; 50 virtual void DidSelectSuggestion(int identifier) OVERRIDE;
51 virtual bool DidAcceptAutofillSuggestion(const string16& value, 51 virtual void DidAcceptSuggestion(const string16& value,
52 int unique_id, 52 int identifier) OVERRIDE;
53 unsigned index) OVERRIDE; 53 virtual void RemoveSuggestion(const string16& value, int identifier) OVERRIDE;
54 virtual void ClearPreviewedForm() OVERRIDE; 54 virtual void ClearPreviewedForm() OVERRIDE;
55 virtual void RemoveAutocompleteEntry(const string16& value) OVERRIDE;
56 virtual void RemoveAutofillProfileOrCreditCard(int unique_id) OVERRIDE;
57 virtual void ControllerDestroyed() OVERRIDE; 55 virtual void ControllerDestroyed() OVERRIDE;
58 56
59 // Records and associates a query_id with web form data. Called 57 // Records and associates a query_id with web form data. Called
60 // when the renderer posts an Autofill query to the browser. |bounds| 58 // when the renderer posts an Autofill query to the browser. |bounds|
61 // is window relative. |display_warning_if_disabled| tells us if we should 59 // is window relative. |display_warning_if_disabled| tells us if we should
62 // display warnings (such as autofill is disabled, but had suggestions). 60 // display warnings (such as autofill is disabled, but had suggestions).
63 // We might not want to display the warning if a website has disabled 61 // We might not want to display the warning if a website has disabled
64 // Autocomplete because they have their own popup, and showing our popup 62 // Autocomplete because they have their own popup, and showing our popup
65 // on to of theirs would be a poor user experience. 63 // on to of theirs would be a poor user experience.
66 virtual void OnQuery(int query_id, 64 virtual void OnQuery(int query_id,
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 // The current data list values. 187 // The current data list values.
190 std::vector<string16> data_list_values_; 188 std::vector<string16> data_list_values_;
191 std::vector<string16> data_list_labels_; 189 std::vector<string16> data_list_labels_;
192 std::vector<string16> data_list_icons_; 190 std::vector<string16> data_list_icons_;
193 std::vector<int> data_list_unique_ids_; 191 std::vector<int> data_list_unique_ids_;
194 192
195 DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate); 193 DISALLOW_COPY_AND_ASSIGN(AutofillExternalDelegate);
196 }; 194 };
197 195
198 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_ 196 #endif // CHROME_BROWSER_AUTOFILL_AUTOFILL_EXTERNAL_DELEGATE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/autofill/autofill_external_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698