Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1163603003: X87: Make KeyedStores from a sloppy arguments array use a handler. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Make KeyedStores from a sloppy arguments array use a handler. port 3a1d7335cf6a623f39c306e0bc0e82ccccc54818 (r28683) original commit message: This finishes up work begun by CL (https://codereview.chromium.org/546683003/) some months ago. BUG= Committed: https://crrev.com/23621d2c113b4f118a93f8cf2f021a6882c66965 Cr-Commit-Position: refs/heads/master@{#28720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -98 lines) Patch
M src/ic/x87/ic-x87.cc View 2 chunks +0 lines, -98 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 6 months ago (2015-06-01 06:15:50 UTC) #2
Weiliang
lgtm
5 years, 6 months ago (2015-06-01 08:24:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163603003/1
5 years, 6 months ago (2015-06-01 08:25:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 09:21:56 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 09:22:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23621d2c113b4f118a93f8cf2f021a6882c66965
Cr-Commit-Position: refs/heads/master@{#28720}

Powered by Google App Engine
This is Rietveld 408576698