Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1163603002: Out-of-flow objects inside multicol may not establish column sets. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Out-of-flow objects inside multicol may not establish column sets. Do a better job at ignoring out-of-flow objects that are not contained by anything inside the multicol container. Previously we only made sure to skip such objects at one specific location in flowThreadDescendantWasInserted(), but this is really needed all over the place, so added utility functions for it. Added an assertion mapDescendantToColumnSet() to catch such situations earlier in the future. BUG=492897 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196234

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 6 months ago (2015-05-28 21:54:43 UTC) #1
dsinclair
lgtm
5 years, 6 months ago (2015-06-01 15:17:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163603002/1
5 years, 6 months ago (2015-06-01 15:17:23 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 16:28:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196234

Powered by Google App Engine
This is Rietveld 408576698