Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11636027: Add ARM toolchain support. (Closed)

Created:
8 years ago by Sam Clegg
Modified:
7 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
git@github.com:samclegg/naclports.git@sbc
Visibility:
Public.

Description

Add ARM toolchain support. The NACL_PACKAGES_BITSIZE environment variable is now deprecated (although still supported) in favour of NACL_ARCH. This new variable can be "i386", "x86_64", "arm", "pnacl", defaults to "i386". BUG= http://code.google.com/p/naclports/issues/detail?id=59 Committed: https://code.google.com/p/naclports/source/detail?r=652

Patch Set 1 : #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : more removal of NACL_PACKAGES_BITSIZE #

Patch Set 6 : remove more use of BITSIZE #

Total comments: 1

Patch Set 7 : revert .c file change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -162 lines) Patch
M Makefile View 4 chunks +15 lines, -12 lines 0 comments Download
M build_tools/bots/bot_common.sh View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M build_tools/bots/linux/nacl-install-linux-ports-0.sh View 1 chunk +1 line, -1 line 0 comments Download
M build_tools/bots/linux/nacl-install-linux-ports-1.sh View 1 chunk +1 line, -1 line 0 comments Download
M build_tools/bots/linux/nacl-install-linux-ports-2.sh View 1 chunk +1 line, -1 line 0 comments Download
M build_tools/bots/pnacl_bots.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build_tools/bots/windows/nacl-install-windows-ports-0.sh View 1 chunk +1 line, -1 line 0 comments Download
M build_tools/bots/windows/nacl-install-windows-ports-1.sh View 1 chunk +1 line, -1 line 0 comments Download
M build_tools/bots/windows/nacl-install-windows-ports-2.sh View 1 chunk +1 line, -1 line 0 comments Download
M build_tools/bots/windows/nacl-install-windows-ports-3.sh View 1 chunk +1 line, -1 line 0 comments Download
M build_tools/bots/windows/nacl-install-windows-ports-4.sh View 1 chunk +1 line, -1 line 0 comments Download
M build_tools/bots/windows/nacl-install-windows-ports-5.sh View 1 chunk +1 line, -1 line 0 comments Download
M build_tools/bots/windows/nacl-install-windows-ports-6.sh View 1 chunk +1 line, -1 line 0 comments Download
M build_tools/buildbot_selector.sh View 4 chunks +7 lines, -7 lines 0 comments Download
M build_tools/common.sh View 1 2 3 4 11 chunks +50 lines, -30 lines 0 comments Download
M common_build_scripts/README.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M examples/audio/openal-ogg/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/games/nethack-3.4.3/nacl-nethack-3.4.3.sh View 3 chunks +3 lines, -3 lines 0 comments Download
M examples/games/scummvm-1.2.1/nacl-scummvm-1.2.1.sh View 1 2 chunks +2 lines, -2 lines 0 comments Download
M examples/games/snes9x-1.53/nacl-snes9x-1.53.sh View 3 chunks +3 lines, -3 lines 0 comments Download
M examples/graphics/photo/Makefile View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M examples/graphics/photo_c_salt/Makefile View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M examples/graphics/xaos/nacl-xaos.sh View 3 chunks +3 lines, -7 lines 0 comments Download
M examples/graphics/xaos/xaos.nmf View 1 1 chunk +2 lines, -2 lines 0 comments Download
M examples/scriptable/crypto/Makefile View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M examples/scriptable/matrix/Makefile View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M examples/scriptable/matrix_npapi/Makefile View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M examples/srpc/notification_center/srpcpp/runtests.sh View 2 chunks +5 lines, -5 lines 0 comments Download
M examples/systems/bochs-2.4.6/nacl-bochs-2.4.6.sh View 5 chunks +8 lines, -8 lines 0 comments Download
M examples/systems/dosbox-0.74/nacl-dosbox-0.74.sh View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M examples/tools/thttpd-2.25b/gen_nmf.sh View 1 2 3 4 2 chunks +9 lines, -7 lines 0 comments Download
M examples/tools/thttpd-2.25b/nacl-thttpd-2.25b.sh View 1 2 3 4 2 chunks +19 lines, -17 lines 0 comments Download
M examples/tutorials/life/life-stage-4/Makefile View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M experimental/v8/run.sh View 7 chunks +9 lines, -9 lines 0 comments Download
M libraries/agg-2.5/nacl-agg-2.5.sh View 1 chunk +1 line, -1 line 0 comments Download
M libraries/ffmpeg-0.5/nacl-ffmpeg-0.5.sh View 1 chunk +1 line, -1 line 0 comments Download
M libraries/fftw-3.2.2/nacl-fftw-3.2.2.sh View 1 chunk +1 line, -1 line 0 comments Download
M libraries/nacl-mounts/nacl-nacl-mounts.sh View 2 chunks +2 lines, -2 lines 0 comments Download
M libraries/openal-soft-1.13/nacl-openal-soft-1.13.sh View 1 chunk +1 line, -1 line 0 comments Download
M libraries/openssl-1.0.0e/nacl-openssl-1.0.0e.sh View 2 chunks +3 lines, -3 lines 0 comments Download
M libraries/x264-snapshot-20091023-2245/nacl-x264-snapshot-20091023-2245.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Sam Clegg
Any tips on how to test this stuff other than just 'make all'?
8 years ago (2012-12-19 21:05:21 UTC) #1
bradn
LGTM Glad to see that variable go. make all is probably your best bet. https://codereview.chromium.org/11636027/diff/2033/examples/tools/thttpd-2.25b/nacl-thttpd-2.25b.sh ...
8 years ago (2012-12-21 19:24:40 UTC) #2
jvoung - send to chromium...
driveby comments https://codereview.chromium.org/11636027/diff/2033/build_tools/bots/bot_common.sh File build_tools/bots/bot_common.sh (right): https://codereview.chromium.org/11636027/diff/2033/build_tools/bots/bot_common.sh#newcode18 build_tools/bots/bot_common.sh:18: ($NACL_PACKAGES_ARCH)" NACL_ARCH or NACL_PACKAGES_ARCH? https://codereview.chromium.org/11636027/diff/2033/build_tools/bots/pnacl_bots.sh File build_tools/bots/pnacl_bots.sh ...
7 years, 12 months ago (2012-12-27 22:09:50 UTC) #3
jvoung - send to chromium...
https://codereview.chromium.org/11636027/diff/2033/Makefile File Makefile (right): https://codereview.chromium.org/11636027/diff/2033/Makefile#newcode61 Makefile:61: $(NACL_SDK_USR) \ Also unrelated issue: I'm not terribly familiar ...
7 years, 12 months ago (2012-12-27 22:19:13 UTC) #4
Sam Clegg
https://codereview.chromium.org/11636027/diff/2033/Makefile File Makefile (right): https://codereview.chromium.org/11636027/diff/2033/Makefile#newcode61 Makefile:61: $(NACL_SDK_USR) \ On 2012/12/27 22:19:13, jvoung wrote: > Also ...
7 years, 12 months ago (2012-12-28 15:31:43 UTC) #5
jvoung - send to chromium...
lgtm
7 years, 12 months ago (2012-12-28 18:36:26 UTC) #6
Sam Clegg
PTAL I've now completely killed all use of NACL_PACKAGES_BITSIZE.
7 years, 11 months ago (2013-01-09 19:21:14 UTC) #7
robertm
LGTM but I would move the .c file change to a different CL
7 years, 11 months ago (2013-01-09 20:04:05 UTC) #8
robertm
7 years, 11 months ago (2013-01-09 20:04:15 UTC) #9 
https://codereview.chromium.org/11636027/diff/34001/examples/audio/openal-ogg...
File examples/audio/openal-ogg/openal_ogg.c (right):

https://codereview.chromium.org/11636027/diff/34001/examples/audio/openal-ogg...
examples/audio/openal-ogg/openal_ogg.c:29: #include "ppapi/c/pp_rect.h"
why was this necessary? maybe move to a CL that goes in before this one

Powered by Google App Engine
This is Rietveld 408576698