Issue 11636022: Use different reply-ports for each test.

Issue 11636022: Use different reply-ports for each test. (Closed)

Created:
8 years ago by floitsch

Modified:
8 years ago

Reviewers:
justinfagnani, siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Create a new ReceivePort for each test so they don't interfere. Committed: https://code.google.com/p/dart/source/detail?r=16389

Patch Set 2 : Better names and status-file update.wq #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -8 lines)			Patch
	M	tests/standalone/package/package_isolate_test.dart	View	1	1 chunk	+10 lines, -8 lines	0 comments	Download
	M	tests/standalone/standalone.status	View	1	1 chunk	+3 lines, -0 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

siva

https://codereview.chromium.org/11636022/diff/2001/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/11636022/diff/2001/tests/standalone/standalone.status#newcode8 tests/standalone/standalone.status:8: package/package_isolate_test: Fail # Issue 7520. I don'see any failure ...

8 years ago (2012-12-20 21:26:40 UTC) #5

floitsch

8 years ago (2012-12-21 09:41:36 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/11636022/diff/2001/tests/standalone/standalon...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/11636022/diff/2001/tests/standalone/standalon...
tests/standalone/standalone.status:8: package/package_isolate_test: Fail # Issue
7520.
On 2012/12/20 21:26:40, siva wrote:
> I don'see any failure when running the test on the VM.
> Here is the output that I get:
> sivalinuxmach[runtime]>out/ReleaseIA32/dart
> ../tests/standalone/package/package_isolate_test.dart
> unittest-suite-wait-for-done
> PASS: package in spawnFunction()
> PASS: package in spawnUri() of sibling file
> PASS: package in spawnUri() of file in folder
> 
> All 3 tests passed.
> unittest-suite-success
> 
> Why does this need to be marked as failing?

On my machine I get 1 failure, and the buildbots seem to agree with me. Did you
patch in the fixes to the test?

Expand Messages | Collapse Messages