Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 11636014: Re-landing https://chromiumcodereview.appspot.com/11587012: Introduce mac_want_real_dsym GYP flag. (Closed)

Created:
8 years ago by Alexander Potapenko
Modified:
8 years ago
Reviewers:
Nico
CC:
chromium-reviews, Mattias Nissler (ping if slow)
Visibility:
Public.

Description

Re-landing https://chromiumcodereview.appspot.com/11587012: Introduce mac_want_real_dsym GYP flag. By default, fake .dSYM files will be generated for regular builds, and dsymutils will be used to create .dSYMs for ASan builds. mac_want_real_dsym can be used to override this. mac_real_dsym can't be set directly, because it's not a % variable. According to https://codereview.chromium.org/113999, it can't be made a % variable now, because of a bug in % handling in GYP that leads to mac_real_dsym being unconditionally set to 1 for some targets. BUG=148383 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173896

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M build/common.gypi View 3 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Alexander Potapenko
8 years ago (2012-12-19 11:08:48 UTC) #1
Nico, TBR

Powered by Google App Engine
This is Rietveld 408576698