Chromium Code Reviews Chromium Code Reviews
Issue 11636011:
Web components based app to view dart docs. Still has rough edges. (Closed)
Base URL: https://github.com/dart-lang/dart-api-app.git@master| Index: client/web/element_summary.html |
| diff --git a/client/web/doc_link.html b/client/web/element_summary.html |
| similarity index 76% |
| copy from client/web/doc_link.html |
| copy to client/web/element_summary.html |
| index c88cb531902545c8caec2c535bdcd23b37346531..38ffc4153a8ded3d762450115181c66d4bb2bc9e 100644 |
| --- a/client/web/doc_link.html |
| +++ b/client/web/element_summary.html |
| @@ -1,38 +1,18 @@ |
| <!DOCTYPE html> |
| -<html><body> |
| - <element name="x-doc-link" constructor="DocLink" extends="span"> |
| - <template> |
| - <template instantiate="if ref.refId != 'void'"> |
| - <a href="{{permalink(ref)}}">{{ref.name}}</a> |
| - </template> |
| - <template instantiate="if ref.refId == 'void'"> |
| - {{ref.name}} |
| - </template> |
| - </template> |
| - <script type="application/dart"> |
| - import 'package:web_ui/web_ui.dart'; |
| - import 'ast.dart'; |
| - import 'model.dart'; |
| - |
| - class DocLink extends WebComponent { |
| - /// Must be a Reference or Element. |
| - var ref; |
| - } |
| - </script> |
| - </element> |
| +<html> |
| + <head> |
| + <link rel="components" href="doc_link.html"> |
| + </head> |
| + <body> |
| <element name="x-member-blocks" constructor="MemberBlocks" extends="div"> |
|
Siggi Cherem (dart-lang)
2012/12/19 19:47:33
you can now remove the 'constructor="MemberBlocks"
Jacob
2013/01/02 19:54:58
Nice :)
Done.
On 2012/12/19 19:47:33, Siggi Chere
|
| <template> |
| <template iterate='block in blocks'> |
| <div> |
| <h3>{{block.kindTitle}}</h3> |
| - <ul> |
| - <template iterate='element in block.elements'> |
| - <li class="{{kindCssClass(element)}}"> |
| - <x-element-summary element="{{element}}"></x-element-summary> |
| - </li> |
| - </template> |
| - </ul> |
| + <template iterate='element in block.elements'> |
| + <x-element-summary element="{{element}}"></x-element-summary> |
| + </template> |
| </div> |
| </template> |
| </template> |
| @@ -56,7 +36,7 @@ |
| </template> |
| </span> |
| <span class="element-definition"> |
| - <span class="element-name"><x-doc-link ref="{{element}}"></x-doc-link></span> |
| + <span class="element-name"><x-doc-link ref="{{element}}" short="{{true}}"></x-doc-link></span> |
|
Siggi Cherem (dart-lang)
2012/12/19 19:47:33
nit: long line, maybe move x-doc-link to it's own
Jacob
2013/01/02 19:54:58
Done.
|
| <template instantiate="if element is MethodElement || element is ConstructorElement || element is TypedefElement"> |
|
Siggi Cherem (dart-lang)
2012/12/19 19:47:33
similarly: consider a getter to describe this cond
Jacob
2013/01/02 19:54:58
Done.
|
| <span class="args">( |
| <template iterate="param in element.parameters"> |
| @@ -87,7 +67,7 @@ |
| <element name="x-element-summary" constructor="ElementSummary" extends="div"> |
| <template> |
| <!--TODO(jacobr): use id instead of data-id and use a different escaping scheme--> |
| - <details class="element-details {{(element is MethodElementBase) ? 'member-details' : 'type-details'}}" data-id="{{element.id}}" open="{{currentMember != null && element.id == currentMember.id}}"> |
| + <details class="element-details {{kindCssClass(element)}} {{(element is MethodElementBase) ? 'member-details' : 'type-details'}}" data-id="{{element.id}}" open="{{currentMember != null && element.id == currentMember.id}}"> |
|
Siggi Cherem (dart-lang)
2012/12/19 19:47:33
long line, consider wrapping on each attribute:
<d
Jacob
2013/01/02 19:54:58
Done.
|
| <summary> |
| <div class="overflow-shadow"></div> |
| <template instantiate="if element is! ClassElement"> |
| @@ -97,9 +77,7 @@ |
| <template instantiate="if element is ClassElement"> |
| <x-doc-link class="element-name element-definition" ref="{{element}}"></x-doc-link> |
|
Siggi Cherem (dart-lang)
2012/12/19 19:47:33
long line
Jacob
2013/01/02 19:54:58
Done.
|
| </template> |
| - <div class="documentation"> |
| - {{element.commentHtml}} |
| - </div> |
| + <div class="documentation">{{element.commentHtml}}</div> |
| </summary> |
| <details class="extended-element-info"> |
| <summary>View ?? comments.</summary> |
| @@ -123,13 +101,15 @@ |
| <template> |
| <template instantiate="if (index < clazz.superclasses.length)"> |
| <div><x-doc-link ref={{clazz.superclasses[index]}}></x-doc-link></div> |
| - <div style="padding-left: 15px"> |
| + <!-- TODO(jacobr): why doesn't it work to just put this class on the |
| + x-class-hierarchy-subtree node? --> |
|
Siggi Cherem (dart-lang)
2012/12/19 19:47:33
maybe a bug in how we propagate properties you set
Jacob
2013/01/02 19:54:58
acknowledged
|
| + <div class="child-subtree"> |
| <x-class-hierarchy-subtree clazz="{{clazz}}" index="{{index+1}}"> |
| </x-class-hierarchy-subtree> |
| </div> |
| </template> |
| <template instantiate="if index == clazz.superclasses.length"> |
| - <div><strong>{{clazz.name}}</strong></div> |
| + <div><strong>{{clazz.shortDescription}}</strong></div> |
| </template> |
| </template> |
| <script type="application/dart"> |
| @@ -160,5 +140,4 @@ |
| } |
| </script> |
| </element> |
| -<!-- more below... --> |
| </body></html> |
