Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 11636003: mac: Fix key view loop regression. (Closed)

Created:
8 years ago by Nico
Modified:
8 years ago
Reviewers:
Robert Sesek, sail
CC:
chromium-reviews, sail+watch_chromium.org, Robert Sesek
Visibility:
Public.

Description

mac: Fix key view loop regression. This bit got lost when moving from a xib file to code. BUG=166385 TEST=Focus omnibox, keep tab pressed. Focus should travel through the web contents too. Open a new tab, repeat. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
I looked into writing a test. Just testing that autorecomputesKeyViewLoop is set seems silly though, ...
8 years ago (2012-12-18 21:07:06 UTC) #1
Robert Sesek
LGTM. I think you'll also have problems testing key state because a non-bundled app can't ...
8 years ago (2012-12-18 21:09:00 UTC) #2
sail
8 years ago (2012-12-18 21:13:29 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698