Add "registerable domain" support to OriginAccessEntry.

Add "registerable domain" support to OriginAccessEntry.

Document::firstPartyForCookies relies on "registerable domain" matching,
as per https://tools.ietf.org/html/draft-west-first-party-cookies-03#section-2.1.
I attempted to introduce this in https://codereview.chromium.org/1133223002,
but misunderstood the 'AllowSubdomains' match setting.

This patch introduces a new 'AllowRegisterableDomains' match setting
which allows, for example, 'www.example.com' to match
'accounts.example.com'. It also adjusts Document::firstPartyForCookies
to use the new setting.

BUG=492971
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196327

[Mike West, 2015-05-29 09:38:43]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2015-05-29 09:38:43]

WDYT, Jochen? We love the PSL, right?

-mike

[jochen (gone - plz use gerrit), 2015-05-29 11:36:43]

https://codereview.chromium.org/1163583005/diff/20001/Source/platform/weborig...
File Source/platform/weborigin/OriginAccessEntry.cpp (right):

https://codereview.chromium.org/1163583005/diff/20001/Source/platform/weborig...
Source/platform/weborigin/OriginAccessEntry.cpp:105: m_registerableDomain =
host.substring(dot + 1);
shouldn't this take this short list into account:
http://hg.mozilla.org/mozilla-central/raw-file/tip/netwerk/dns/effective_tld_...

[Mike West, 2015-05-29 12:06:42]

https://codereview.chromium.org/1163583005/diff/20001/Source/platform/weborig...
File Source/platform/weborigin/OriginAccessEntry.cpp (right):

https://codereview.chromium.org/1163583005/diff/20001/Source/platform/weborig...
Source/platform/weborigin/OriginAccessEntry.cpp:105: m_registerableDomain =
host.substring(dot + 1);
On 2015/05/29 11:36:43, jochen wrote:
> shouldn't this take this short list into account:
>
http://hg.mozilla.org/mozilla-central/raw-file/tip/netwerk/dns/effective_tld_...

It does, insofar as the start position of the `reverseFind` is dictated by the
public suffix list (line 96). That is, given `www.example.com`, it will find
`com` as the suffix, walk backwards to the next '.', and use `example.com` as
the registerable domain.

[jochen (gone - plz use gerrit), 2015-06-01 12:57:41]

after some offline discussion, Mike promised me a test with a public suffix that
contains dots, preferable something like appspot.com (which also has the public
suffix com)

[Mike West, 2015-06-02 06:57:35]

Thanks for reminding me of my promise. Test is up in the latest patchset.

[Mike West, 2015-06-02 11:56:27]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-02 11:56:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163583005/40001

[commit-bot: I haz the power, 2015-06-02 11:59:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 11:59:22]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2015-06-02 16:20:39]

lgtm

[Mike West, 2015-06-02 16:23:43]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-06-02 16:23:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163583005/40001

[commit-bot: I haz the power, 2015-06-02 16:28:00]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196327