Provide tag-along for SkCreateTypefaceFromCTFont.

Provide tag-along for SkCreateTypefaceFromCTFont.

This provides a means of keeping an object alive for the entire
lifetime of an SkTypeface.

Committed: https://skia.googlesource.com/skia/+/788840168f819240b2ad61d693149cd81ee24302

[bungeman-skia, 2015-06-08 18:02:32]

bungeman@google.com changed reviewers:
+ reed@google.com

[bungeman-skia, 2015-06-08 18:02:33]

This is the Skia side of an attempt to work around https://crbug.com/413332 .

[bungeman-skia, 2015-06-08 18:21:37]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-08 18:22:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163573007/20001

[reed1, 2015-06-08 19:01:40]

So, we have several places where we want to communicate to the client when a
given Skia object dies
- SkImage
- SkPixelRef
- SkData
...

All of those take a function-ptr/context.

Do you think we should use this general pattern for these fonts as well?

https://codereview.chromium.org/1163573007/diff/20001/src/ports/SkFontHost_ma...
File src/ports/SkFontHost_mac.cpp (right):

https://codereview.chromium.org/1163573007/diff/20001/src/ports/SkFontHost_ma...
src/ports/SkFontHost_mac.cpp:432: CFTypeRef resourceRef = NULL)
remove default argness?

https://codereview.chromium.org/1163573007/diff/20001/src/ports/SkFontHost_ma...
src/ports/SkFontHost_mac.cpp:475: CFTypeRef resourceRef = NULL)
since its internal, lets remove the defaultness of this arg

[bungeman-skia, 2015-06-08 19:14:40]

https://codereview.chromium.org/1163573007/diff/20001/src/ports/SkFontHost_ma...
File src/ports/SkFontHost_mac.cpp (right):

https://codereview.chromium.org/1163573007/diff/20001/src/ports/SkFontHost_ma...
src/ports/SkFontHost_mac.cpp:432: CFTypeRef resourceRef = NULL)
On 2015/06/08 19:01:40, reed1 wrote:
> remove default argness?

Done.

https://codereview.chromium.org/1163573007/diff/20001/src/ports/SkFontHost_ma...
src/ports/SkFontHost_mac.cpp:475: CFTypeRef resourceRef = NULL)
On 2015/06/08 19:01:40, reed1 wrote:
> since its internal, lets remove the defaultness of this arg

Done.

[bungeman-skia, 2015-06-08 19:23:07]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-08 19:23:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163573007/40001

[bungeman-skia, 2015-06-08 19:26:27]

Note that this isn't to notify anyone that the typeface died, this is an attempt
to work around what is probably a bug in CoreText/CoreGraphics. Basically, the
CTFont doesn't seem to hold onto the underlying data in some cases.

[commit-bot: I haz the power, 2015-06-08 19:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-08 19:30:55]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-06-08 20:18:31]

link to some roadmap bug (new) that tracks your idea for eventually replacing
createfromctfont entirely.

lgtm

[bungeman-skia, 2015-06-08 20:33:09]

The CQ bit was checked by bungeman@google.com

[bungeman-skia, 2015-06-08 20:33:10]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1163573007/#ps60001
(title: "Add reference to bug.")

[commit-bot: I haz the power, 2015-06-08 20:33:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1163573007/60001

[commit-bot: I haz the power, 2015-06-08 20:39:22]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/788840168f819240b2ad61d693149cd81ee24302