Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1163523008: [test] Fix missing heartbeats in test runner. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix missing heartbeats in test runner. TBR=jkummerow@chromium.org Committed: https://crrev.com/e728125131a6a6638da0af1d0b95c5d3f368667b Cr-Commit-Position: refs/heads/master@{#28808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/testrunner/local/progress.py View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Achenbach
PTAL. The hearbeat method is simply not called when the indicators are chained. The output ...
5 years, 6 months ago (2015-06-05 09:21:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163523008/1
5 years, 6 months ago (2015-06-05 09:26:19 UTC) #4
tandrii(chromium)
lgtm
5 years, 6 months ago (2015-06-05 09:34:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163523008/1
5 years, 6 months ago (2015-06-05 09:35:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 09:50:57 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 09:51:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e728125131a6a6638da0af1d0b95c5d3f368667b
Cr-Commit-Position: refs/heads/master@{#28808}

Powered by Google App Engine
This is Rietveld 408576698