Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 1163523006: Revert of Mandoline filesystem: Enable windows build. (Closed)

Created:
5 years, 6 months ago by Elliot Glaysher
Modified:
5 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mandoline filesystem: Enable windows build. (patchset #8 id:140001 of https://codereview.chromium.org/1163713002/) Reason for revert: Patch failed on Win 8 GN: FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/filesystem/filesystem_library.file_impl.obj.rsp /c ../../components/filesystem/file_impl.cc /Foobj/components/filesystem/filesystem_library.file_impl.obj /Fdobj/components/filesystem/filesystem_library_cc.pdb e:\b\build\slave\win_x64_gn\build\src\components\filesystem\file_impl.cc(129) : error C2220: warning treated as error - no 'object' file generated e:\b\build\slave\win_x64_gn\build\src\components\filesystem\file_impl.cc(129) : warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data Original issue's description: > Mandoline filesystem: Build the filesystem on windows. > > This resolves name collisions with #defines in windows.h and does os specific path handling in a few places. > > BUG=490237 > > Committed: https://crrev.com/3e8be89d1827aed47a9deeb7d1b6745258c17000 > Cr-Commit-Position: refs/heads/master@{#332073} TBR=sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490237 Committed: https://crrev.com/50d829befd7b63ec3e70e4b4373a05564aa07547 Cr-Commit-Position: refs/heads/master@{#332075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -323 lines) Patch
M components/filesystem/directory_impl.cc View 5 chunks +19 lines, -21 lines 0 comments Download
M components/filesystem/directory_impl_unittest.cc View 3 chunks +31 lines, -31 lines 0 comments Download
M components/filesystem/file_impl.cc View 16 chunks +55 lines, -60 lines 0 comments Download
M components/filesystem/file_impl_unittest.cc View 18 chunks +129 lines, -129 lines 0 comments Download
M components/filesystem/file_system_impl.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M components/filesystem/files_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/filesystem/public/interfaces/directory.mojom View 2 chunks +5 lines, -5 lines 0 comments Download
M components/filesystem/public/interfaces/file.mojom View 2 chunks +10 lines, -10 lines 0 comments Download
M components/filesystem/public/interfaces/file_system.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/filesystem/public/interfaces/types.mojom View 4 chunks +4 lines, -7 lines 0 comments Download
M components/filesystem/util.h View 1 chunk +7 lines, -7 lines 0 comments Download
M components/filesystem/util.cc View 4 chunks +33 lines, -43 lines 0 comments Download
M mandoline/BUILD.gn View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
Created Revert of Mandoline filesystem: Enable windows build.
5 years, 6 months ago (2015-05-29 23:27:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1163523006/1
5 years, 6 months ago (2015-05-29 23:29:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-29 23:30:40 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 23:31:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50d829befd7b63ec3e70e4b4373a05564aa07547
Cr-Commit-Position: refs/heads/master@{#332075}

Powered by Google App Engine
This is Rietveld 408576698