LayoutTests/http/tests/inspector/network/network-preview-json.html - Issue 1163523002: DevTools: remove hand-written optimistic JSON parser introduced in r183821.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/inspector/network/network-preview-json.html

Issue 1163523002: DevTools: remove hand-written optimistic JSON parser introduced in r183821. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: with more test cases Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/inspector/network/network-preview-json-expected.txt » ('j') | Source/devtools/front_end/network/RequestJSONView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/inspector/network/network-preview-json.html

diff --git a/LayoutTests/http/tests/inspector/network/network-preview-json.html b/LayoutTests/http/tests/inspector/network/network-preview-json.html

index 29fb5c0ee995753a47fbecddc654663112d2b48c..81846d6e8cee993567e826aacf14c276e01fcfe0 100644

--- a/LayoutTests/http/tests/inspector/network/network-preview-json.html

+++ b/LayoutTests/http/tests/inspector/network/network-preview-json.html

@@ -21,12 +21,13 @@ function test()

check("{\"name\": \"value\"}");

check("while(1); {\"name\": \"value\"}");

- check("[,\"foo\", -4.2, true, false, null]");

+ check("[null, \"foo\", -4.2, true, false, null]");

check("[{\"foo\": {}, \"bar\": []},[[],{}]]");

- check("/* vanilla */ run([1, 2, 3]);");

+ check("/* vanilla */ run ( [1, 2, 3] ) ;");

check("[\"A\\\"B\\u0020C\\nD\\\\E\\u04ABF\"]");

- check("<html>404 Page not found</html>");

+ check("Text with with {} inside");

+ check("<html>404 Page not found with foo({}) inside</html>");

+ check("/* vanilla prefix too large to be considered prefix Ok? */ run([1, 2, 3]); // since it is unlikely JSONP");

InspectorTest.completeTest();

}