chrome/browser/spellchecker/spelling_service_client.cc - Issue 11635063: [Spellcheck] Removing the "no more suggestions from Google" line when using the spelling service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spelling_service_client.cc

Issue 11635063: [Spellcheck] Removing the "no more suggestions from Google" line when using the spelling service (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: responding to comments (browsertest, prebind) Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spelling_service_client.h ('k') | chrome/browser/spellchecker/spelling_service_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spelling_service_client.cc

diff --git a/chrome/browser/spellchecker/spelling_service_client.cc b/chrome/browser/spellchecker/spelling_service_client.cc

index 1ba862d5b4f5cd38ee285e970b8c1884fd7ab8e8..baa590eb3d2c89db6f79aeb002d37b5f843c0849 100644

--- a/chrome/browser/spellchecker/spelling_service_client.cc

+++ b/chrome/browser/spellchecker/spelling_service_client.cc

@@ -28,7 +28,7 @@

#define SPELLING_SERVICE_URL "https://www.googleapis.com/rpc"

#endif

-SpellingServiceClient::SpellingServiceClient() : tag_(0) {

+SpellingServiceClient::SpellingServiceClient() {

}

SpellingServiceClient::~SpellingServiceClient() {

@@ -36,7 +36,6 @@ SpellingServiceClient::~SpellingServiceClient() {

bool SpellingServiceClient::RequestTextCheck(

Profile* profile,

- int tag,

ServiceType type,

const string16& text,

const TextCheckCompleteCallback& callback) {

@@ -97,7 +96,6 @@ bool SpellingServiceClient::RequestTextCheck(

fetcher_->SetLoadFlags(

net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES);

fetcher_->Start();

- tag_ = tag;

text_ = text;

callback_ = callback;

return true;

@@ -146,7 +144,7 @@ void SpellingServiceClient::OnURLFetchComplete(

source->GetResponseAsString(&data);

success = ParseResponse(data, &results);

}

- callback_.Run(tag_, success, text_, results);

+ callback_.Run(success, text_, results);

}

net::URLFetcher* SpellingServiceClient::CreateURLFetcher(const GURL& url) {