[Spellcheck] Removing the "no more suggestions from Google" line when using the spelling service

chrome/browser/spellchecker/spelling_service_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/spellchecker/spelling_service_client.h"
 
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/json/string_escape.h"
 #include "base/logging.h"
@@ skipping 82 matching lines @@
   GURL url = GURL(kSpellingServiceURL);
   fetcher_.reset(CreateURLFetcher(url));
   fetcher_->SetRequestContext(profile->GetRequestContext());
   fetcher_->SetUploadData("application/json", request);
   fetcher_->SetLoadFlags(
       net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES);
   fetcher_->Start();
   tag_ = tag;
   text_ = text;
   callback_ = callback;
+  type_ = type;

[groby-ooo-7-16, 2012/12/21 22:18:13]

Since tag_ and type_ are only needed when we run the callback, would it make
more sense to pre-bind them? (The fact that the callback needs a type_ and a
tag_ is an implementation detail)

[rpetterson, 2013/01/04 00:05:34]

Done.

   return true;
 }
 
 bool SpellingServiceClient::IsAvailable(Profile* profile, ServiceType type) {
   const PrefService* pref = profile->GetPrefs();
   if (!pref->GetBoolean(prefs::kEnableContinuousSpellcheck) ||
       !pref->GetBoolean(prefs::kSpellCheckUseSpellingService))
     return false;
 
   // If the locale for spelling has not been set, the user has not decided to
@@ skipping 26 matching lines @@
 void SpellingServiceClient::OnURLFetchComplete(
     const net::URLFetcher* source) {
   scoped_ptr<net::URLFetcher> clean_up_fetcher(fetcher_.release());
   bool success = false;
   std::vector<SpellCheckResult> results;
   if (source->GetResponseCode() / 100 == 2) {
     std::string data;
     source->GetResponseAsString(&data);
     success = ParseResponse(data, &results);
   }
-  callback_.Run(tag_, success, text_, results);
+  callback_.Run(tag_, success, type_, text_, results);
 }
 
 net::URLFetcher* SpellingServiceClient::CreateURLFetcher(const GURL& url) {
   return net::URLFetcher::Create(url, net::URLFetcher::POST, this);
 }
 
 bool SpellingServiceClient::ParseResponse(
     const std::string& data,
     std::vector<SpellCheckResult>* results) {
   // When this JSON-RPC call finishes successfully, the Spelling service returns
@@ skipping 63 matching lines @@
     if (!suggestions->GetDictionary(0, &suggestion) ||
         !suggestion->GetString("suggestion", &replacement)) {
       return false;
     }
     SpellCheckResult result(
         SpellCheckResult::SPELLING, start, length, replacement);
     results->push_back(result);
   }
   return true;
 }