Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: utils/pub/http.dart

Issue 11635060: Add a validator for dependency version constraints. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/entrypoint.dart ('k') | utils/pub/validator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/http.dart
diff --git a/utils/pub/http.dart b/utils/pub/http.dart
index b46435c20178e6b3329fd34236279383daeedc0e..032a047bd6370bacc472dddd50efbfcf9c5f30e4 100644
--- a/utils/pub/http.dart
+++ b/utils/pub/http.dart
@@ -24,10 +24,10 @@ final HTTP_TIMEOUT = 30 * 1000;
/// An HTTP client that transforms 40* errors and socket exceptions into more
/// user-friendly error messages.
class PubHttpClient extends http.BaseClient {
- final http.Client _inner;
+ http.Client inner;
PubHttpClient([http.Client inner])
- : _inner = inner == null ? new http.Client() : inner;
+ : this.inner = inner == null ? new http.Client() : inner;
Future<http.StreamedResponse> send(http.BaseRequest request) {
// TODO(rnystrom): Log request body when it's available and plaintext, but
@@ -43,7 +43,7 @@ class PubHttpClient extends http.BaseClient {
// TODO(nweiz): Ideally the timeout would extend to reading from the
// response input stream, but until issue 3657 is fixed that's not feasible.
- return timeout(_inner.send(request).chain((streamedResponse) {
+ return timeout(inner.send(request).chain((streamedResponse) {
log.fine("Got response ${streamedResponse.statusCode} "
"${streamedResponse.reasonPhrase}.");
« no previous file with comments | « utils/pub/entrypoint.dart ('k') | utils/pub/validator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698