chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js - Issue 11635038: Should not unregister BookmarkTreeItem from lookup table on handling moved event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js

Issue 11635038: Should not unregister BookmarkTreeItem from lookup table on handling moved event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js

diff --git a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js

index 3f235f9b02881b6fa19b5a86c1370b3b8baa573f..63064b79556dc4e8e0bf018f85b7f5e2e2be1f8c 100644

--- a/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js

+++ b/chrome/browser/resources/bookmark_manager/js/bmm/bookmark_tree.js

@@ -193,7 +193,7 @@ cr.define('bmm', function() {

var treeItem = treeLookup[id];

if (treeItem) {

var oldParentItem = treeLookup[moveInfo.oldParentId];

- oldParentItem.remove(treeItem);

+ TreeItem.prototype.remove.call(oldParentItem, treeItem);

arv (Not doing code reviews) 2012/12/20 14:54:51 This seems pretty hacky. Is there an alternative s

var newParentItem = treeLookup[moveInfo.parentId];

// The tree only shows folders so the index is not the index we want. We

// therefore get the children need to adjust the index.

« no previous file with comments | « no previous file | no next file » | no next file with comments »