Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 11635026: Merge 138181 (Closed)

Created:
8 years ago by leviw_travelin_and_unemployed
Modified:
8 years ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 138181 > Correct missing touch event handler de-registration for nested Documents and DOMWindows > https://bugs.webkit.org/show_bug.cgi?id=105384 > > Reviewed by James Robinson. > > Source/WebCore: > > Correcting case by which a nested DOMWindow wouldn't clean up its event handler references > on its Document when removeAllEventListeners was called. Also, correctly propagating this > from a nested Document to its owner Document. > > Updating fast/events/touch/touch-handler-count.html to catch this bug. > > * dom/Document.cpp: > (WebCore::Document::didRemoveEventTargetNode): > * page/DOMWindow.cpp: > (WebCore::DOMWindow::removeAllEventListeners): > > LayoutTests: > > * fast/events/touch/touch-handler-count-expected.txt: > * fast/events/touch/touch-handler-count.html: Adding case of nested DOMWindows with event handlers. > TBR=leviw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M LayoutTests/fast/events/touch/touch-handler-count.html View 1 chunk +19 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/touch-handler-count-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebCore/dom/Document.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/page/DOMWindow.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
leviw_travelin_and_unemployed
8 years ago (2012-12-19 20:46:33 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698