Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 11635019: [chromedriver] Fix issue of converting parameter to JSON. (Closed)

Created:
8 years ago by chrisgao (Use stgao instead)
Modified:
8 years ago
Reviewers:
kkania
CC:
chromium-reviews
Visibility:
Public.

Description

[chromedriver] Fix converting embedded capabilities object to JSON. This allows Java to find a given Chrome exe via the capabilities. Patch from Shuotao Gao <chrisgao@chromium.org>;. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173967

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
M patch.diff View 5 chunks +18 lines, -20 lines 0 comments Download
M test-standalone.jar View Binary file 0 comments Download

Messages

Total messages: 2 (0 generated)
chrisgao (Use stgao instead)
8 years ago (2012-12-19 18:28:43 UTC) #1
kkania
8 years ago (2012-12-19 19:07:54 UTC) #2
lgtm, i'll patch it for you

Powered by Google App Engine
This is Rietveld 408576698