Issue 11635015: Generalize calling to C++ on stub deopt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11635015: Generalize calling to C++ on stub deopt (Closed)

Created:
8 years ago by danno

Modified:
7 years, 11 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Generalize calling to C++ on stub deopt Remove code specific to KeyedLoadICs in DoCompiledStubFrame on all platforms, driving stub frame translation by the register parameter information found in a stub's CodeStubInterfaceDescriptor. Committed: http://code.google.com/p/v8/source/detail?r=13320

Patch Set 1 #

Patch Set 2 : Fixes #

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -120 lines)			Patch
M	src/arm/builtins-arm.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/deoptimizer-arm.cc	View	1	2 chunks	+42 lines, -35 lines	0 comments	Download
M	src/builtins.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/code-stubs.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/builtins-ia32.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View	1	2 chunks	+41 lines, -35 lines	0 comments	Download
M	src/ic.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/runtime.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/builtins-x64.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View	1	2 chunks	+41 lines, -35 lines	0 comments	Download
M	test/mjsunit/fuzz-natives-part1.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

danno

Remove code specific to KeyedLoadICs in DoCompiledStubFrame on all platforms, driving stub frame translation by ...

7 years, 11 months ago (2013-01-02 14:47:33 UTC) #1

Sven Panne

7 years, 11 months ago (2013-01-03 08:17:01 UTC) #2

LGTM. A general remark: The various deoptimizer functions on all our platforms
contain so much (often architecture-independent) boilerplate code by now that we
should really consider a major refactoring here...

Expand Messages | Collapse Messages